From: Chris Mason <chris.mason@oracle.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: Chuck Ebbert <cebbert@redhat.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: Build failure with latest -git: btrfs on ppc64
Date: Mon, 09 Feb 2009 09:57:26 -0500 [thread overview]
Message-ID: <1234191446.1262.3.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090207232458.GB23407@bombadil.infradead.org>
On Sat, 2009-02-07 at 18:24 -0500, Kyle McMartin wrote:
> On Sat, Feb 07, 2009 at 03:50:39PM -0500, Chuck Ebbert wrote:
> > fs/btrfs/locking.c: In function 'btrfs_path_lock_waiting':
> > fs/btrfs/locking.c:254: error: implicit declaration of function '__raw_spin_is_contended'
> >
> > Looks like spin_is_contended() is only available on mips and x86??
> >
>
> Looks to be if there are other folks in line for the ticket lock.
>
> Arguably this should probably be something silly in spinlock.h like,
>
> #ifndef __raw_spin_is_contended
> # define spin_is_contended (0)
> #else
> # define spin_is_contended(x) __raw_spin_is_contended((x))
> #endif
>
> or something since in theory anybody has a chance of acquiring it next
> (well, lies because caches bias, but there's no waiters at least.)
>
> Either that, or we just define it to be spin_is_locked if the assumption
> is that the lock will continue to be locked...
Ok, I thought this would be defined to something simple for the
non-ticket users, should I just not be using this call?
-chris
next prev parent reply other threads:[~2009-02-09 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 20:50 Build failure with latest -git: btrfs on ppc64 Chuck Ebbert
2009-02-07 23:24 ` Kyle McMartin
2009-02-09 14:57 ` Chris Mason [this message]
2009-02-09 15:57 ` Kyle McMartin
2009-02-09 16:05 ` Chris Mason
2009-02-09 21:39 ` Jeff Mahoney
2009-02-09 21:36 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234191446.1262.3.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=cebbert@redhat.com \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox