Re: [PATCH v2 0/2] qnx4: Avoid confusing compiler about buffer lengths

Kees Cook
2023-12-04T22:10:24Z

On Tue, Dec 05, 2023 at 01:46:27AM +1000, Ronald Monthero wrote:
> Cheers Kees,
> BR,
> ronald

Is this a "Tested-by"? :)

-Kees

>
>
> On Fri, Dec 1, 2023 at 6:51 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > Hi,
> >
> > This attempts to fix the issue Ronald Monthero found[1]. Avoids using a
> > too-short struct buffer when reading the string, by using the existing
> > struct union.
> >
> > -Kees
> >
> > [1] https://lore.kernel.org/lkml/20231112095353.579855-1-debug.penguin32@gmail.com/
> >
> > v2:
> > - Use BUILD_BUG_ON() instead of _Static_assert()
> > v1: https://lore.kernel.org/all/20231118032638.work.955-kees@kernel.org/
> >
> > Kees Cook (2):
> > qnx4: Extract dir entry filename processing into helper
> > qnx4: Use get_directory_fname() in qnx4_match()
> >
> > fs/qnx4/dir.c | 52 ++++++------------------------------------
> > fs/qnx4/namei.c | 29 +++++++++---------------
> > fs/qnx4/qnx4.h | 60 +++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 78 insertions(+), 63 deletions(-)
> >
> > --
> > 2.34.1
> >

--
Kees Cook