Re: [PATCH v2 0/2] qnx4: Avoid confusing compiler about buffer lengths

Kees Cook
2023-12-13T19:18:23Z

On Wed, Dec 13, 2023 at 05:43:08PM +0100, Anders Larsen wrote:
> Hi Kees,
>
> On 2023-12-12 22:19 Kees Cook wrote:
> > On Thu, 30 Nov 2023 12:51:17 -0800, Kees Cook wrote:
> > > This attempts to fix the issue Ronald Monthero found[1]. Avoids using a
> > > too-short struct buffer when reading the string, by using the existing
> > > struct union.
> > >
> > > -Kees
> > >
> > > [1]
> > > https://lore.kernel.org/lkml/20231112095353.579855-1-debug.penguin32@gmai
> > > l.com/
> > >
> > > [...]
> >
> > I'll put these in -next since there's been no more discussion on it.
> >
> > Applied to for-next/hardening, thanks!
>
> thanks for taking care of this (and apologies for me being unresponsive)
>
> If it's not too late, feel free to add
> Acked-by: Anders Larsen <al@alarsen.net>

Thanks! I'll update the tags. :)

--
Kees Cook