From: Chris Mason <chris.mason@oracle.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: Chuck Ebbert <cebbert@redhat.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: Build failure with latest -git: btrfs on ppc64
Date: Mon, 09 Feb 2009 11:05:39 -0500 [thread overview]
Message-ID: <1234195539.5447.2.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090209155702.GB13529@bombadil.infradead.org>
On Mon, 2009-02-09 at 10:57 -0500, Kyle McMartin wrote:
> On Mon, Feb 09, 2009 at 09:57:26AM -0500, Chris Mason wrote:
> >
> > Ok, I thought this would be defined to something simple for the
> > non-ticket users, should I just not be using this call?
> >
>
> I think the use is fine, since it's really a judgement call based on
> whether there's waiters for the ticket. I need to take a closer look
> at where this is used to say...
>
The Btrfs use goes something like this:
I'm about to wait for the disk. If there are other procs waiting for
the locks I'm holding, I'll drop my locks and do a somewhat expensive
btree search over again later so the waiters can make progress.
If nobody is waiting, I'll do my read with my locks held so that I don't
have to search again.
> It's inevitable for you to hit things like this though, as far as I know
> you're the first user of this lock interface. :)
;)
-chris
next prev parent reply other threads:[~2009-02-09 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 20:50 Build failure with latest -git: btrfs on ppc64 Chuck Ebbert
2009-02-07 23:24 ` Kyle McMartin
2009-02-09 14:57 ` Chris Mason
2009-02-09 15:57 ` Kyle McMartin
2009-02-09 16:05 ` Chris Mason [this message]
2009-02-09 21:39 ` Jeff Mahoney
2009-02-09 21:36 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234195539.5447.2.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=cebbert@redhat.com \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox