From: Chris Mason <chris.mason@oracle.com>
To: Chuck Ebbert <cebbert@redhat.com>,
Kyle McMartin <kyle@infradead.org>,
jeffm@suse.de, Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: Build failure with latest -git: btrfs on ppc64
Date: Mon, 09 Feb 2009 16:36:11 -0500 [thread overview]
Message-ID: <1234215371.17365.16.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090207155039.3b6a7429@dhcp-100-2-144.bos.redhat.com>
On Sat, 2009-02-07 at 15:50 -0500, Chuck Ebbert wrote:
> fs/btrfs/locking.c: In function 'btrfs_path_lock_waiting':
> fs/btrfs/locking.c:254: error: implicit declaration of function '__raw_spin_is_contended'
>
> Looks like spin_is_contended() is only available on mips and x86??
Btrfs was using spin_is_contended to decide if it should drop locks
before doing an expensive operation during the core btree search. After
a few latency tests here, I think it makes more sense to always drop
them instead.
Linus, if you pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.git
You'll get the build fix for btrfs on arches without ticket spinlocks
fs/btrfs/ctree.c | 3 +--
fs/btrfs/locking.c | 22 ----------------------
fs/btrfs/locking.h | 2 --
3 files changed, 1 insertion(+), 26 deletions(-)
-chris
prev parent reply other threads:[~2009-02-09 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 20:50 Build failure with latest -git: btrfs on ppc64 Chuck Ebbert
2009-02-07 23:24 ` Kyle McMartin
2009-02-09 14:57 ` Chris Mason
2009-02-09 15:57 ` Kyle McMartin
2009-02-09 16:05 ` Chris Mason
2009-02-09 21:39 ` Jeff Mahoney
2009-02-09 21:36 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234215371.17365.16.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=cebbert@redhat.com \
--cc=jeffm@suse.de \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox