From: Brian Gerst <brgerst@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] x86: Drop -fno-stack-protector after pt_regs fixes
Date: Tue, 10 Feb 2009 09:51:47 -0500 [thread overview]
Message-ID: <1234277507-4987-4-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1234277507-4987-1-git-send-email-brgerst@gmail.com>
Now that no functions rely on struct pt_regs being passed by value,
stack protector can be enabled.
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/kernel/Makefile | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index b1f8be3..37fa30b 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -24,24 +24,6 @@ CFLAGS_vsyscall_64.o := $(PROFILING) -g0 $(nostackp)
CFLAGS_hpet.o := $(nostackp)
CFLAGS_tsc.o := $(nostackp)
CFLAGS_paravirt.o := $(nostackp)
-#
-# On x86_32, register frame is passed verbatim on stack as struct
-# pt_regs. gcc considers the parameter to belong to the callee and
-# with -fstack-protector it copies pt_regs to the callee's stack frame
-# to put the structure after the stack canary causing changes made by
-# the exception handlers to be lost. Turn off stack protector for all
-# files containing functions which take struct pt_regs from register
-# frame.
-#
-# The proper way to fix this is to teach gcc that the argument belongs
-# to the caller for these functions, oh well...
-#
-ifdef CONFIG_X86_32
-CFLAGS_process_32.o := $(nostackp)
-CFLAGS_vm86_32.o := $(nostackp)
-CFLAGS_signal.o := $(nostackp)
-CFLAGS_traps.o := $(nostackp)
-endif
obj-y := process_$(BITS).o signal.o entry_$(BITS).o
obj-y += traps.o irq.o irq_$(BITS).o dumpstack_$(BITS).o
--
1.6.1
next prev parent reply other threads:[~2009-02-10 14:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 14:51 [PATCH 0/3] x86: Fix pt_regs passed by value Brian Gerst
2009-02-10 14:51 ` [PATCH 1/3] x86: Use pt_regs pointer in do_device_not_available() Brian Gerst
2009-02-11 7:43 ` Tejun Heo
2009-02-11 10:13 ` Ingo Molnar
2009-02-11 14:34 ` Brian Gerst
2009-02-11 14:42 ` Tejun Heo
2009-02-11 14:46 ` Brian Gerst
2009-02-11 14:53 ` Tejun Heo
2009-02-10 14:51 ` [PATCH 2/3] x86: Pass in pt_regs pointer for syscalls that need it Brian Gerst
2009-02-11 7:41 ` Tejun Heo
2009-02-11 10:18 ` Ingo Molnar
2009-02-11 14:14 ` Tejun Heo
2009-02-11 14:31 ` Brian Gerst
2009-02-11 14:41 ` Tejun Heo
2009-02-11 14:43 ` Tejun Heo
2009-02-11 14:48 ` Tejun Heo
2009-02-11 14:58 ` Ingo Molnar
2009-02-11 14:59 ` Brian Gerst
2009-02-11 15:05 ` Tejun Heo
2009-02-11 15:10 ` Brian Gerst
2009-02-11 15:14 ` Tejun Heo
2009-02-11 15:59 ` Ingo Molnar
2009-02-12 1:12 ` Tejun Heo
2009-02-11 15:01 ` Ingo Molnar
2009-02-11 17:52 ` H. Peter Anvin
2009-02-11 18:27 ` Brian Gerst
2009-02-11 19:50 ` H. Peter Anvin
2009-02-11 19:57 ` Brian Gerst
2009-02-11 20:00 ` H. Peter Anvin
2009-02-11 21:43 ` [PATCH] x86: pass in pt_regs pointer for syscalls that need it (take 2) Brian Gerst
2009-02-11 21:50 ` H. Peter Anvin
2009-02-11 22:06 ` H. Peter Anvin
2009-02-12 11:02 ` Ingo Molnar
2009-02-10 14:51 ` Brian Gerst [this message]
2009-02-11 11:42 ` [PATCH 0/3] x86: Fix pt_regs passed by value Ingo Molnar
2009-02-11 14:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234277507-4987-4-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox