Re: [PATCH NET-NEXT 0/10] hardware time stamping with new fields in shinfo

David Miller
2009-02-16T07:16:55Z

From: Patrick Ohly <patrick.ohly@intel.com>
Date: Thu, 12 Feb 2009 16:03:01 +0100

> This revision of the patch series transports hardware time stamps from
> the hardware into user space via additional fields in struct
> skb_shared_info. It's based on net-next-2.6 as of this morning.
>
> This is the solution that emerged from the discussion of the other
> approaches suggested before (reuse tstamp, extend skbuff, optional
> structs): it has the advantage of not touching skbuff and also has the
> simplest implementation.
>
> The clocksource and timecompare patches have been reviewed by John
> Stultz. He doesn't mind merging them via the net subtree.
>
> John Ronciak reviewed the igb driver patches. He suggested to merge the
> patches as they; after all, PTPd already works fine. I just tested again
> on 32 and 64 bit x86, both with the timestamping example programs as
> well as with PTPd. Latest patched PTPd is here:
> http://github.com/pohly/ptpd/tree/master
>
> The open TODOs in the igb driver will be fixed. We think that this will
> be easier with the infrastructure and the driver in a regular kernel
> tree.

Ok, I applied everything and pushed it out to net-next-2.6, let's
see how this goes :-)

That TX clone wrt. skb_orphan() issue will need a happier solution.

Can you describe that problem in detail? Maybe someone can come
up with a way to avoid that stuff.

Thanks.