From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760148AbZBMAwQ (ORCPT ); Thu, 12 Feb 2009 19:52:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757330AbZBMAv7 (ORCPT ); Thu, 12 Feb 2009 19:51:59 -0500 Received: from mga09.intel.com ([134.134.136.24]:46245 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754420AbZBMAv6 (ORCPT ); Thu, 12 Feb 2009 19:51:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.38,199,1233561600"; d="scan'208";a="489614977" Subject: Re: [PATCH 1/1] ipw2200, fix ipw io functions From: Zhu Yi To: Jiri Slaby Cc: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "ipw2100-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , James Ketrenos , "Chatre, Reinette" In-Reply-To: <1234474180-910-1-git-send-email-jirislaby@gmail.com> References: <1234474180-910-1-git-send-email-jirislaby@gmail.com> Content-Type: text/plain Date: Fri, 13 Feb 2009 08:49:40 +0800 Message-Id: <1234486180.6354.203.camel@debian> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-02-13 at 05:29 +0800, Jiri Slaby wrote: > /* alias to 8-bit direct read (low 4K of SRAM/regs), with debug > wrapper */ > -#define ipw_read8(ipw, ofs) __ipw_read8(__FILE__, __LINE__, ipw, ofs) > +#define ipw_read8(ipw, ofs) ({ \ > + IPW_DEBUG_IO("%s %d: read_direct8(0x%08X)\n", __FILE__, __LINE__, \ > + (u32)(ofs)); \ > + _ipw_read8(ipw, ofs); \ > +}) Please put a do {} while(0) for this and some of below macros as well. Thanks, -yi