From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Nick Piggin <npiggin@suse.de>, akpm <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <mhiramat@redhat.com>,
ananth@in.ibm.com, davem@davemloft.net
Subject: Re: irq-disabled vs vmap vs text_poke
Date: Fri, 13 Feb 2009 15:28:57 +0100 [thread overview]
Message-ID: <1234535337.6519.111.camel@twins> (raw)
In-Reply-To: <20090213141839.GA31922@Krystal>
Ok, lets CC kprobes folk
On Fri, 2009-02-13 at 09:18 -0500, Mathieu Desnoyers wrote:
>
> text_poke should actually use local_irq_disable/enable rather than
> local_irq_save/restore because it _must_ be called with interrupts on.
>
> > Anybody got an idea on how to fix this?
>
> There is probably something wrong with the caller, kprobes, which calls
> text_poke with interrupts off.
next prev parent reply other threads:[~2009-02-13 14:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 12:50 irq-disabled vs vmap vs text_poke Peter Zijlstra
2009-02-13 12:55 ` Nick Piggin
2009-02-13 13:02 ` Peter Zijlstra
2009-02-13 13:04 ` Ingo Molnar
2009-02-13 14:25 ` Mathieu Desnoyers
2009-02-13 14:33 ` Peter Zijlstra
2009-02-13 14:43 ` Mathieu Desnoyers
2009-02-13 18:05 ` Ingo Molnar
2009-02-13 13:05 ` Peter Zijlstra
2009-02-13 13:09 ` Nick Piggin
2009-02-13 14:18 ` Mathieu Desnoyers
2009-02-13 14:28 ` Peter Zijlstra [this message]
2009-02-13 16:32 ` Masami Hiramatsu
2009-02-13 16:38 ` Peter Zijlstra
2009-02-13 16:55 ` Mathieu Desnoyers
2009-02-13 18:14 ` Masami Hiramatsu
2009-02-13 18:57 ` Mathieu Desnoyers
2009-02-13 21:41 ` Masami Hiramatsu
2009-02-16 15:04 ` Masami Hiramatsu
2009-02-16 15:31 ` Nick Piggin
2009-02-16 17:24 ` Mathieu Desnoyers
2009-02-17 2:00 ` Masami Hiramatsu
2009-02-17 3:03 ` Nick Piggin
2009-02-17 8:31 ` Peter Zijlstra
2009-02-17 17:13 ` Masami Hiramatsu
2009-02-17 16:48 ` Masami Hiramatsu
2009-02-17 17:02 ` Steven Rostedt
2009-02-17 17:18 ` Mathieu Desnoyers
2009-02-17 17:24 ` Steven Rostedt
2009-02-17 17:28 ` Mathieu Desnoyers
2009-02-17 17:48 ` Steven Rostedt
2009-02-13 14:27 ` [PATCH] x86: text_poke might sleep Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234535337.6519.111.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox