From: "Alexander van Heukelum" <heukelum@fastmail.fm>
To: "Cyrill Gorcunov" <gorcunov@gmail.com>,
"Ingo Molnar" <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
"Jan Beulich" <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/6] x86 tip asm ENTRY,ENDPROC cleanup
Date: Sat, 14 Feb 2009 00:23:31 +0100 [thread overview]
Message-ID: <1234567411.13034.1300286953@webmail.messagingengine.com> (raw)
In-Reply-To: <20090213215017.959278111@gmail.com>
On Sat, 14 Feb 2009 00:50:17 +0300, "Cyrill Gorcunov"
<gorcunov@gmail.com> said:
> Hi,
>
> here is a small series of cleanups for assembler
> files. Not sure if introducing new GLOBAL macro
> was a good idea but code got shorter form of
> writting.
>
> Please review. Any comments are highly appreciated.
Hi Cyrill,
I like this direction. If I understand correctly:
ENTRY/END or GLOBAL/END for data.
ENTRY/ENDPROC or GLOBAL/ENDPROC for functions.
The patches look sound. You're welcome to add:
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
Greetings,
Alexander
> Cyrill
--
Alexander van Heukelum
heukelum@fastmail.fm
--
http://www.fastmail.fm - Access your email from home and the web
next prev parent reply other threads:[~2009-02-13 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 21:50 [RFC 0/6] x86 tip asm ENTRY,ENDPROC cleanup Cyrill Gorcunov
2009-02-13 21:50 ` [RFC 1/6] x86: asm linkage - introduce GLOBAL macro Cyrill Gorcunov
2009-02-13 21:50 ` [RFC 2/6] x86: linkage - get rid of _X86 macros Cyrill Gorcunov
2009-02-13 21:50 ` [RFC 3/6] x86: copy.S - use GLOBAL,ENDPROC macros Cyrill Gorcunov
2009-02-13 21:50 ` [RFC 4/6] x86: pmjump " Cyrill Gorcunov
2009-02-13 21:50 ` [RFC 5/6] x86: compressed head_64 - use ENTRY,ENDPROC macros Cyrill Gorcunov
2009-02-13 21:50 ` [RFC 6/6] x86: compressed head_32 " Cyrill Gorcunov
2009-02-13 23:23 ` Alexander van Heukelum [this message]
2009-02-14 0:34 ` [RFC 0/6] x86 tip asm ENTRY,ENDPROC cleanup H. Peter Anvin
2009-02-14 8:21 ` Cyrill Gorcunov
2009-02-14 11:42 ` Alexander van Heukelum
2009-02-14 20:02 ` H. Peter Anvin
2009-02-19 16:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234567411.13034.1300286953@webmail.messagingengine.com \
--to=heukelum@fastmail.fm \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox