public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Greg KH <greg@kroah.com>
Cc: Colin Ian King <colin.king@canonical.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth USB: fix kernel panic during suspend - 2.6.24
Date: Sat, 14 Feb 2009 13:53:22 +0100	[thread overview]
Message-ID: <1234616002.7293.192.camel@violet> (raw)
In-Reply-To: <20090213190953.GA958@kroah.com>

Hi Greg,

> > The kernel panics when hci_usb_tx_complete() calls _urb_unlink()
> > on an _urb which has been previously been removed from a list.
> > This occurs during suspend while audio is being streamed to
> > a bluetooth headset.
> > 
> > The panic occurs because hci_usb_suspend() dequeues _urb
> > and then calls usb_kill_urb() - instead it should put _urb on
> > the killed list first before killing the urb.
> > 
> > Also added a spin_lock around the list_add operation.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Is this still an issue on a supported-by-the-community kernel (.27, .28,
> .29)?

starting with 2.6.29 the hci_usb driver has been replaced by btusb.

Regards

Marcel



      reply	other threads:[~2009-02-14 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13  9:49 [PATCH] Bluetooth USB: fix kernel panic during suspend - 2.6.24 Colin Ian King
2009-02-13 19:09 ` Greg KH
2009-02-14 12:53   ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234616002.7293.192.camel@violet \
    --to=marcel@holtmann.org \
    --cc=colin.king@canonical.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox