From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbZBNOq4 (ORCPT ); Sat, 14 Feb 2009 09:46:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751898AbZBNOqr (ORCPT ); Sat, 14 Feb 2009 09:46:47 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:40193 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbZBNOqr (ORCPT ); Sat, 14 Feb 2009 09:46:47 -0500 Subject: [PATCH 1.5/2] generic-smp: fix initial quiesent count. From: Peter Zijlstra To: Linus Torvalds Cc: Nick Piggin , Jens Axboe , "Paul E. McKenney" , Ingo Molnar , Rusty Russell , linux-kernel@vger.kernel.org, Oleg Nesterov In-Reply-To: <1234622474.4698.25.camel@laptop> References: <20090212223200.979433820@chello.nl> <20090212223750.295581470@chello.nl> <1234622474.4698.25.camel@laptop> Content-Type: text/plain Date: Sat, 14 Feb 2009 15:46:32 +0100 Message-Id: <1234622792.4698.31.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.25.90 Content-Transfer-Encoding: 7bit X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org first compile, then send out... --- Subject: generic-smp: fix initial quiesent count. From: Peter Zijlstra Date: Sat Feb 14 15:36:07 CET 2009 If we start with a quiesent sequence count of 0, we'll match the initial stamp values of the cfd_data, and never make any progress. To avoid getting stuck in this situation, start out with an increased quiesent sequence count. Signed-off-by: Peter Zijlstra --- kernel/smp.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6/kernel/smp.c =================================================================== --- linux-2.6.orig/kernel/smp.c +++ linux-2.6/kernel/smp.c @@ -27,6 +27,7 @@ static struct { } call_function __cacheline_aligned_in_smp = { .queue = LIST_HEAD_INIT(call_function.queue), .lock = __SPIN_LOCK_UNLOCKED(call_function.lock), + .quiesent = 1, }; enum {