From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755408AbZBRUSu@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755408AbZBRUSu (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Feb 2009 15:18:50 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752180AbZBRUSk
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 18 Feb 2009 15:18:40 -0500
Received: from accolon.hansenpartnership.com ([76.243.235.52]:35450 "EHLO
	accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751570AbZBRUSj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Feb 2009 15:18:39 -0500
Subject: Re: [PATCH] pci: enable MSI on 8132
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
       david@lang.hm, Matthew Wilcox <matthew@wil.cx>,
       Jesse Barnes <jbarnes@virtuousgeek.org>,
       linux-kernel <linux-kernel@vger.kernel.org>, linux-scsi@vger.kernel.org,
       DL-MPTFusionLinux@lsi.com, linux-pci@vger.kernel.org
In-Reply-To: <499C6BC9.6010706@garzik.org>
References: <499B46B2.5040601@kernel.org>
	 <alpine.DEB.1.10.0902171537260.26625@asgard.lang.hm>
	 <499B6BF7.9090300@kernel.org>
	 <alpine.DEB.1.10.0902171803040.26625@asgard.lang.hm>
	 <499B724A.2040408@kernel.org>
	 <alpine.DEB.1.10.0902171832560.26625@asgard.lang.hm>
	 <alpine.DEB.1.10.0902171839420.26625@asgard.lang.hm>
	 <499B774C.5010705@kernel.org>
	 <alpine.DEB.1.10.0902171917420.26625@asgard.lang.hm>
	 <499B9129.50104@kernel.org> <20090218122137.GJ16841@parisc-linux.org>
	 <alpine.DEB.1.10.0902180426420.25606@asgard.lang.hm>
	 <20090218100448.7f7c5b86.akpm@linux-foundation.org>
	 <1234982285.3225.42.camel@localhost.localdomain>
	 <499C5CAD.1070404@kernel.org>
	 <1234984495.3225.48.camel@localhost.localdomain>
	 <499C6BC9.6010706@garzik.org>
Content-Type: text/plain
Date: Wed, 18 Feb 2009 14:18:33 -0600
Message-Id: <1234988313.22084.43.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2009-02-18 at 15:12 -0500, Jeff Garzik wrote:
> James Bottomley wrote:
> > Like I said, I'm happy to have MSI completely disabled until LSI wants
> > to comment, so no ... only the PCI quirk fix.  The true fix is to have
> > the drivers participate in dynamic testing of MSI IRQ routing, but I've
> > somewhat lost sight of that.
> 
> That's not really a fix at all, just additional, unneeded overhead for 
> 99% of users.  We don't need our drivers bloated with self-check code 
> for all the components in our various computer chips...

So you think the current per driver variably named parameter to turn off
MSI is better?  Especially as most of the users who trip across a
platform having MSI problems don't even know that the storage failure is
caused by MSI, let alone how to find the parameter to fix the problem.

James