Re: [PATCH] SDIO driver for Marvell SoCs

[Harvey Harrison <harvey.harrison@gmail.com>]

On Thu, 2009-02-19 at 14:53 -0800, Andrew Morton wrote:
> On Thu, 19 Feb 2009 17:02:32 -0500 (EST)
> Nicolas Pitre <nico@cam.org> wrote:
> 
> > On Thu, 19 Feb 2009, Andrew Morton wrote:
> > 
> > > On Tue, 17 Feb 2009 23:46:21 -0500 (EST)
> > > Nicolas Pitre <nico@cam.org> wrote:
> > > 
> > > > +#define mvsd_write(offs, val)	writel(val, iobase + (offs))
> > > > +#define mvsd_read(offs)		readl(iobase + (offs))
> > > 
> > > It's rather grotty to have a macro which secretly relies upon the
> > > presence of a particularly-named local variable.
> > 
> > My call.  Otherwise the code becomes bloated with repeated iobase noise 
> > everywhere, making many lines bust the 80 column limit imposed by the 
> > checkpatch.pl.  The alternative is to split those statement on multiple 
> > lines making things not prettier.  So, unless you want to help 
> > maintaining this driver, I prefer this grottiness to remains as is.
> 
> For the record: you do not get to put bad code into Linux by telling
> the person who points out that bad code that he needs to maintain a
> fixed verion.  Just cut the sophomoric crap.
> 
> I don't care much - we have plenty of grotty code down in drivers/

I think this is a not-so-uncommon pattern in network drivers. FWIW

Harvey