From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbZBWJTj (ORCPT ); Mon, 23 Feb 2009 04:19:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751892AbZBWJTa (ORCPT ); Mon, 23 Feb 2009 04:19:30 -0500 Received: from casper.infradead.org ([85.118.1.10]:49285 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbZBWJT3 (ORCPT ); Mon, 23 Feb 2009 04:19:29 -0500 Subject: Re: [PATCH 15/20] Do not disable interrupts in free_page_mlock() From: Peter Zijlstra To: Mel Gorman Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin In-Reply-To: <1235344649-18265-16-git-send-email-mel@csn.ul.ie> References: <1235344649-18265-1-git-send-email-mel@csn.ul.ie> <1235344649-18265-16-git-send-email-mel@csn.ul.ie> Content-Type: text/plain Date: Mon, 23 Feb 2009 10:19:00 +0100 Message-Id: <1235380740.4645.2.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.25.91 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2009-02-22 at 23:17 +0000, Mel Gorman wrote: > free_page_mlock() tests and clears PG_mlocked. If set, it disables interrupts > to update counters and this happens on every page free even though interrupts > are disabled very shortly afterwards a second time. This is wasteful. > > This patch splits what free_page_mlock() does. The bit check is still > made. However, the update of counters is delayed until the interrupts are > disabled. One potential weirdness with this split is that the counters do > not get updated if the bad_page() check is triggered but a system showing > bad pages is getting screwed already. > > Signed-off-by: Mel Gorman > --- > mm/internal.h | 10 ++-------- > mm/page_alloc.c | 8 +++++++- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 478223b..b52bf86 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -155,14 +155,8 @@ static inline void mlock_migrate_page(struct page *newpage, struct page *page) > */ > static inline void free_page_mlock(struct page *page) > { > - if (unlikely(TestClearPageMlocked(page))) { > - unsigned long flags; > - > - local_irq_save(flags); > - __dec_zone_page_state(page, NR_MLOCK); > - __count_vm_event(UNEVICTABLE_MLOCKFREED); > - local_irq_restore(flags); > - } > + __dec_zone_page_state(page, NR_MLOCK); > + __count_vm_event(UNEVICTABLE_MLOCKFREED); > } Its not actually clearing PG_mlocked anymore, so the name is now a tad misleading. That said, since we're freeing the page, there ought to not be another reference to the page, in which case it appears to me we could safely use the unlocked variant of TestClear*().