From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbZBWKPW (ORCPT ); Mon, 23 Feb 2009 05:15:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752102AbZBWKPH (ORCPT ); Mon, 23 Feb 2009 05:15:07 -0500 Received: from gate.crashing.org ([63.228.1.57]:55979 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbZBWKPG (ORCPT ); Mon, 23 Feb 2009 05:15:06 -0500 Subject: Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume From: Benjamin Herrenschmidt To: "Eric W. Biederman" Cc: Ingo Molnar , "Rafael J. Wysocki" , Linus Torvalds , LKML , Jeremy Fitzhardinge , pm list , Len Brown , Jesse Barnes , Thomas Gleixner In-Reply-To: References: <200902221837.49396.rjw@sisk.pl> <200902222342.08285.rjw@sisk.pl> <200902230048.33635.rjw@sisk.pl> <20090223084400.GB9582@elte.hu> Content-Type: text/plain Date: Mon, 23 Feb 2009 21:13:06 +1100 Message-Id: <1235383986.8805.239.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-02-23 at 01:22 -0800, Eric W. Biederman wrote: > Ingo Molnar writes: > > > > I think this aspect has been well-understood during the > > discussion of this topic and it's just a slightly misleading > > changelog. > > As I was a member of that discussion I did not see that. > > It took me several passes through the patches to realize > the goal is to allow drivers to be able to sleep while they > are in their late pm shutdown routines. > > Why we want this I don't know. But it seems simple enough > to implement, and it makes it harder to get the late pm > suspend routines wrong, which is always good. To simplify (it's really all in the discussion we had the last few weeks) It boils down to being able to do the proper ACPI calls (which require core interrupts to be on, ie, ACPI uses mutexes, sleeps, etc...) after we have saved and before we restore the PCI config space, in the late suspend or early resume stages of devices. Cheers, Ben.