From: Li Wei <W.Li@Sun.COM>
To: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Huang Ying <ying.huang@intel.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 3/4] gcov: add gcov profiling infrastructure
Date: Thu, 26 Feb 2009 10:40:05 +0800 [thread overview]
Message-ID: <1235616005.7351.8.camel@localhost> (raw)
In-Reply-To: <49883CD7.2060602@linux.vnet.ibm.com>
node->parent is always NULL, causing NULL-pointer dereference in
remove_node.
Could you please include something like this?
---
kernel/gcov/fs.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index 0084492..6675c82 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -374,6 +374,7 @@ static struct gcov_node *new_node(struct gcov_node *parent,
return NULL;
}
init_node(node, info, name);
+ node->parent = parent;
/* Differentiate between gcov data file nodes and directory nodes. */
if (info) {
node->dentry = debugfs_create_file(deskew(node->name), 0600,
--
1.5.6.3
next prev parent reply other threads:[~2009-02-26 2:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 12:47 [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-02-03 15:31 ` Ingo Molnar
2009-02-04 16:48 ` Peter Oberparleiter
2009-02-26 2:40 ` Li Wei [this message]
2009-02-26 10:00 ` Peter Oberparleiter
2009-02-26 10:33 ` Li Wei
2009-02-26 12:57 ` Peter Oberparleiter
2009-02-26 10:11 ` Li Wei
2009-02-26 11:46 ` Peter Oberparleiter
2009-02-26 12:08 ` Li Wei
2009-02-26 12:55 ` Peter Oberparleiter
-- strict thread matches above, loose matches on Subject: below --
2009-02-26 13:52 Peter Oberparleiter
2009-05-07 12:45 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-07 12:45 ` [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-05-07 13:46 ` Ingo Molnar
2009-05-07 13:49 ` Ingo Molnar
2009-05-08 11:10 ` Peter Oberparleiter
2009-05-11 13:17 ` Ingo Molnar
2009-05-12 13:09 ` Peter Oberparleiter
2009-05-12 13:35 ` Ingo Molnar
2009-05-08 15:44 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-08 15:44 ` [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-05-12 15:38 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-12 15:38 ` [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-05-19 14:24 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-19 14:24 ` [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-05-19 15:00 ` Ingo Molnar
2009-05-22 8:55 ` Peter Oberparleiter
2009-05-22 9:22 ` Andi Kleen
2009-06-02 11:43 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-06-02 11:44 ` [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-06-02 22:03 ` Andrew Morton
2009-06-03 2:34 ` Michael Ellerman
2009-06-03 11:57 ` Peter Oberparleiter
2009-06-03 15:26 ` Peter Oberparleiter
2009-06-03 16:01 ` Michael Ellerman
2009-06-03 21:39 ` Andrew Morton
2009-06-04 8:26 ` Peter Oberparleiter
2009-06-04 8:40 ` Andrew Morton
2009-06-05 13:05 ` Peter Oberparleiter
2009-06-04 9:08 ` Amerigo Wang
2009-06-05 9:23 ` Peter Oberparleiter
2009-06-05 9:34 ` Andrew Morton
2009-06-05 10:12 ` Peter Oberparleiter
2009-06-06 8:30 ` Michael Ellerman
2009-06-08 8:24 ` Peter Oberparleiter
2009-06-05 9:55 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235616005.7351.8.camel@localhost \
--to=w.li@sun.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=sam@ravnborg.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).