Re: [PATCH 2/4] zedtrace generic kernel filtering

[Tom Zanussi <tzanussi@gmail.com>]

On Sat, 2009-02-28 at 10:26 +0100, Ingo Molnar wrote:
> * Tom Zanussi <tzanussi@gmail.com> wrote:
> 
> > Add generic kernel filtering.
> > 
> > Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
> > 
> > ---
> >  kernel/trace/trace_binary/Makefile     |    2 +-
> >  kernel/trace/trace_binary/zed.c        |  103 +++++++++--
> >  kernel/trace/trace_binary/zed.h        |   15 ++
> >  kernel/trace/trace_binary/zed_filter.c |  301 ++++++++++++++++++++++++++++++++
> >  kernel/trace/trace_binary/zed_filter.h |   45 +++++
> >  kernel/trace/trace_binary/zed_sched.c  |    4 +
> >  6 files changed, 451 insertions(+), 19 deletions(-)
> >  create mode 100644 kernel/trace/trace_binary/zed_filter.c
> >  create mode 100644 kernel/trace/trace_binary/zed_filter.h
> 
> Nice!
> 

Thanks!

> This fits really nicely into the ftrace principles and i'd love 
> to see this feature merged into ftrace - would you be interested 
> in working on that? If so then you can find the latest tracing 

Sure, but I'm not too familiar with the ftrace code and wouldn't have
big blocks of time to devote to it, so if it's something that's needed
"right away", I'll probably have to defer to letting someone else adapt
the code if they wanted to.

> tree at:
> 
>     http://people.redhat.com/mingo/tip.git/README
> 
> Note that Steve added explicit field enumeration and 'raw' C 
> syntax tracepoints to the event tracer earlier today (partly 
> based on your ideas here), so that would be a good basis to 
> extend/enhance/fix, if you are interested.
> 

Yeah, I took a quick look and saw some nice improvements.  Anyway, the
filtering I did for this was basically a side-effect of the event
description stuff, which made the filtering relatively easy to do (and
the event description files give the user a way to list the available
fields).  What I'm wondering is if you're interested in the filtering
part alone or in the event description part as well, which I hadn't
thought of as separable (I guess I need to look at the current ftrace
code to see what's already there).

Thanks,

Tom

> Thanks,
> 
> 	Ingo