From: Jason Noble <nobleja@polezero.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: New HID device support
Date: Wed, 04 Mar 2009 09:47:11 -0500 [thread overview]
Message-ID: <1236178031.9121.6.camel@paradox.pz.local> (raw)
In-Reply-To: <alpine.LNX.2.00.0903041436210.4971@jikos.suse.cz>
I made a minor tweak. Please include in the official patch.
(BTN_2 and BTN_3, are not very useful xev doesn't even see them)
- case 0x01: ks_map_key(BTN_2); break;
- case 0x02: ks_map_key(BTN_3); break;
+ case 0x01: ks_map_key(BTN_MIDDLE); break;
+ case 0x02: ks_map_key(BTN_SIDE); break;
Other than that, it works great!
You are awesome, thank you very very much!!
P.S.
I think the failed patch issues were caused by email eating the code
format. Manually editing the failed patch files worked.
On Wed, 2009-03-04 at 14:37 +0100, Jiri Kosina wrote:
> On Wed, 4 Mar 2009, Jason Noble wrote:
>
> > Sorry to be such a bother.
> > Attached .rej files if they help.
> >
> > clean just untared 2.6.28.7
> >
> > patching file a/drivers/hid/Kconfig
> > Hunk #1 succeeded at 157 with fuzz 2.
> > patching file a/drivers/hid/Makefile
> > Hunk #1 FAILED at 30.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > a/drivers/hid/Makefile.rej
> > patching file a/drivers/hid/hid-core.c
> > Hunk #1 FAILED at 1271.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > a/drivers/hid/hid-core.c.rej
> > patching file a/drivers/hid/hid-dummy.c
> > Hunk #1 succeeded at 34 with fuzz 2.
> > patching file a/drivers/hid/hid-ids.h
> > Hunk #1 FAILED at 279.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > a/drivers/hid/hid-ids.h.rej
> > patching file b/drivers/hid/hid-kensington.c
> > paradox:/usr/src# ls a/drivers/hid/Makefile.rej
> > a/drivers/hid/Makefile.rej
>
> Odd, the patch I sent you was based on 2.6.28.7.
>
> You can just add the lines from .rej files manually, it's only 6 lines of
> code or so.
>
next prev parent reply other threads:[~2009-03-04 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1236096277.26321.29.camel@paradox.pz.local>
2009-03-03 16:21 ` New HID device support Jiri Kosina
2009-03-03 18:01 ` Jason Noble
2009-03-03 18:04 ` Jiri Kosina
2009-03-03 19:04 ` Jason Noble
2009-03-04 10:45 ` Jiri Kosina
2009-03-04 13:08 ` Jason Noble
2009-03-04 13:15 ` Jason Noble
2009-03-04 13:20 ` Jiri Kosina
2009-03-04 13:34 ` Jason Noble
2009-03-04 13:37 ` Jiri Kosina
2009-03-04 14:47 ` Jason Noble [this message]
2009-03-04 15:13 ` Jiri Kosina
2009-03-04 15:16 ` Jason Noble
2009-03-04 22:56 ` Jiri Kosina
2009-03-05 12:51 ` Jason Noble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236178031.9121.6.camel@paradox.pz.local \
--to=nobleja@polezero.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox