From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756561AbZCEC0m (ORCPT ); Wed, 4 Mar 2009 21:26:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754269AbZCEC0R (ORCPT ); Wed, 4 Mar 2009 21:26:17 -0500 Received: from gate.crashing.org ([63.228.1.57]:36660 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756075AbZCEC0Q (ORCPT ); Wed, 4 Mar 2009 21:26:16 -0500 Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook From: Benjamin Herrenschmidt To: Gaudenz Steinlin Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton In-Reply-To: <20090304083859.GB6889@soziologie.ch> References: <20090304083859.GB6889@soziologie.ch> Content-Type: text/plain Date: Thu, 05 Mar 2009 13:25:20 +1100 Message-Id: <1236219920.7260.6.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-03-04 at 09:38 +0100, Gaudenz Steinlin wrote: > Hi Benjamin > > The commit 1fb25cb8b83e85f5bf1a4adb3c9a254c4ce92405 "radeonfb: Fix resume > from D3Cold on some platforms" breaks resume from suspend to RAM on my > PowerBook (Model PowerBook5,8 with ATI Mobility Radeon 9600 M10). > > On resume the pulsing led indicating sleep just changes to solid white > and nothing else happens. > > Reverting this commit on top of the current Linus' tree fixes resume. Ok, so after some tests here on what appear to the the exact same machine... I did the commit specifically to -fix- a regression due to upstream changes, ie, for me it doesn't work without that commit. That is very weird. In fact, I just tried also with AGP and DRM enabled with X wobbly windows etc... and it's working just fine. I know that the early resume hack I have in there for powerbooks might be a bit fishy, so please try without it (according to my previous email on that matter). Please let me know if that makes a difference. Cheers, Ben.