From: Daniel Silverstone <dsilvers@simtec.co.uk>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Richard Hughes <hughsient@gmail.com>,
linux-acpi@vger.kernel.org, toshiba_acpi@memebeam.org,
linux-kernel@vger.kernel.org, len.brown@intel.com
Subject: Re: [PATCH] toshiba_acpi: Add full hotkey support
Date: Fri, 06 Mar 2009 10:21:49 +0000 [thread overview]
Message-ID: <1236334909.19146.16.camel@petitemort> (raw)
In-Reply-To: <20090306101533.GA6408@srcf.ucam.org>
On Fri, 2009-03-06 at 10:15 +0000, Matthew Garrett wrote:
> > I see. One other thing occurred to me. Is there any way for Hal to know
> > that the notify stuff is in place and thus doesn't need to
> > poll /proc/acpi/toshiba/keys? Otherwise it's going to poll it anyway
> > which fails to remove the periodic wakeups.
> No. Distributions should build without --enable-toshiba if they ship a
> kernel with this functionaliy.
This only makes sense if all the rest of /proc/acpi/toshiba/* is now
implemented in proper modern kernel facilities. I noticed rfkill
switches (although I'll have to see if another is needed for the HSDPA
modems in modern laptops) and a proper brightness control. I assume
xrandr does what video did, which just leaves the fan control.
D.
--
Daniel Silverstone http://www.simtec.co.uk/
PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895
next prev parent reply other threads:[~2009-03-06 10:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 0:39 [PATCH] toshiba_acpi: Add full hotkey support Matthew Garrett
2009-03-06 0:52 ` Matthew Garrett
2009-03-06 9:08 ` Richard Hughes
2009-03-06 9:47 ` Daniel Silverstone
2009-03-06 9:56 ` Matthew Garrett
2009-03-06 10:04 ` Daniel Silverstone
2009-03-06 10:09 ` Matthew Garrett
2009-03-06 10:12 ` Daniel Silverstone
2009-03-06 10:15 ` Matthew Garrett
2009-03-06 10:21 ` Daniel Silverstone [this message]
2009-03-06 18:49 ` Andrey Borzenkov
2009-03-06 18:53 ` Matthew Garrett
2009-03-06 18:37 ` Andrey Borzenkov
2009-03-06 18:44 ` Matthew Garrett
2009-03-06 18:57 ` Andrey Borzenkov
2009-03-07 7:27 ` Andrey Borzenkov
2009-03-07 15:06 ` Matthew Garrett
2009-03-07 15:38 ` Andrey Borzenkov
2009-03-07 15:44 ` Matthew Garrett
2009-03-07 20:19 ` Richard Hughes
2009-03-07 20:26 ` Matthew Garrett
2009-03-08 8:33 ` Richard Hughes
2009-03-08 14:29 ` Andrey Borzenkov
2009-03-08 14:36 ` Matthew Garrett
2009-03-09 17:11 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236334909.19146.16.camel@petitemort \
--to=dsilvers@simtec.co.uk \
--cc=hughsient@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshiba_acpi@memebeam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox