Re: [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller

Rob Herring
2024-05-13T18:58:14Z

On Fri, May 10, 2024 at 09:01:33PM +0200, Stefan Wahren wrote:
> Hi Andrea,
>
> please drop E. Anholt from the recipients. AFAIK she is not interested
> in kernel development anymore.
>
> Am 10.05.24 um 16:35 schrieb Andrea della Porta:
> > The BCM2712 has an SDHCI capable host interface similar to the one found
> > in other STB chipsets. Add the relevant compatible string and relative
> > example.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > index cbd3d6c6c77f..404b75fa7adb 100644
> > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > @@ -13,6 +13,10 @@ maintainers:
> > properties:
> > compatible:
> > oneOf:
> > + - items:
> > + - enum:
> > + - brcm,bcm2712-sdhci
> > + - const: brcm,sdhci-brcmstb
> > - items:
> > - enum:
> > - brcm,bcm7216-sdhci
> > @@ -114,3 +118,22 @@ examples:
> > clocks = <&scmi_clk 245>;
> > clock-names = "sw_sdio";
> > };
> > +
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> Would be nice to have a short explanation in the commit message why this
> is necessary.

That has nothing to do with *this* patch. It's needed because 'reg' is
dependent on it and the examples default to 1 cell.

In any case, please just drop the example. A new compatible doesn't
justify another example.

Rob