public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kurz <gkurz@fr.ibm.com>
To: Daniel Lezcano <daniel.lezcano@free.fr>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Containers <containers@lists.osdl.org>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	roland@redhat.com
Subject: Re: [PATCH 0/7][v8] Container-init signal semantics
Date: Sat, 07 Mar 2009 20:51:49 +0100	[thread overview]
Message-ID: <1236455509.9151.4.camel@bahia> (raw)
In-Reply-To: <49B2CE6E.3090501@free.fr>

On Sat, 2009-03-07 at 20:43 +0100, Daniel Lezcano wrote:
>         case LINUX_REBOOT_CMD_HALT:
> -               kernel_halt();
> -               unlock_kernel();
> -               do_exit(0);
> +               if (power_off_pid_ns(current->nsproxy->pid_ns)) {
> +                       kernel_halt();
> +                       unlock_kernel();
> +                       do_exit(0);
> +               }

Even if current will get SIGKILLed when zap_pid_ns_processes() is
called, I see no reason it doesn't call do_exit(0).

>                 break;
> 
>         case LINUX_REBOOT_CMD_POWER_OFF:
> -               kernel_power_off();
> -               unlock_kernel();
> -               do_exit(0);
> +               if (power_off_pid_ns(current->nsproxy->pid_ns)) {
> +                       kernel_power_off();
> +                       unlock_kernel();
> +                       do_exit(0);
> +               }

Same.

>                 break;
> 
-- 
Gregory Kurz                                     gkurz@fr.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)534 638 479                           Fax +33 (0)561 400 420

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.


  reply	other threads:[~2009-03-07 19:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19  3:02 [PATCH 0/7][v8] Container-init signal semantics Sukadev Bhattiprolu
2009-02-19  3:05 ` [PATCH 1/7][v8] Remove 'handler' parameter to tracehook functions Sukadev Bhattiprolu
2009-02-19  3:05 ` [PATCH 2/7][v8] Protect init from unwanted signals more Sukadev Bhattiprolu
2009-02-19  3:06 ` [PATCH 3/7][v8] Add from_ancestor_ns parameter to send_signal() Sukadev Bhattiprolu
2009-02-19  3:06 ` [PATCH 4/7][v8] Protect cinit from unblocked SIG_DFL signals Sukadev Bhattiprolu
2009-02-19  3:07 ` [PATCH 5/7][v8] zap_pid_ns_process() should use force_sig() Sukadev Bhattiprolu
2009-02-19 18:59   ` Oleg Nesterov
2009-02-19 20:26     ` Sukadev Bhattiprolu
2009-02-19  3:07 ` [PATCH 6/7][v8] Protect cinit from blocked fatal signals Sukadev Bhattiprolu
2009-02-19  3:07 ` [PATCH 7/7][v8] SI_USER: Masquerade si_pid when crossing pid ns boundary Sukadev Bhattiprolu
2009-02-19 16:11   ` Eric W. Biederman
2009-02-19 18:51     ` Oleg Nesterov
2009-02-19 22:18       ` Eric W. Biederman
2009-02-19 22:31         ` Oleg Nesterov
2009-02-19 23:21           ` Eric W. Biederman
2009-02-19 23:51             ` Roland McGrath
2009-02-20  0:35               ` Eric W. Biederman
2009-02-20  1:06                 ` Roland McGrath
2009-02-20  2:12                   ` Eric W. Biederman
2009-02-20  3:10                     ` Roland McGrath
2009-02-20  4:05                       ` Eric W. Biederman
2009-02-20  0:28             ` Oleg Nesterov
2009-02-20  1:16               ` Eric W. Biederman
2009-02-19 14:59 ` [PATCH 0/7][v8] Container-init signal semantics Daniel Lezcano
2009-03-07 19:04   ` Sukadev Bhattiprolu
2009-03-07 19:43     ` Daniel Lezcano
2009-03-07 19:51       ` Greg Kurz [this message]
2009-03-07 19:59         ` Daniel Lezcano
2009-02-19 20:53 ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236455509.9151.4.camel@bahia \
    --to=gkurz@fr.ibm.com \
    --cc=akpm@osdl.org \
    --cc=containers@lists.osdl.org \
    --cc=daniel.lezcano@free.fr \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox