From: Peter Zijlstra <peterz@infradead.org>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git-pull -tip] x86:perf_counter cleanup
Date: Sun, 08 Mar 2009 11:20:43 +0100 [thread overview]
Message-ID: <1236507643.22914.3642.camel@twins> (raw)
In-Reply-To: <1236507232.28127.2.camel@localhost.localdomain>
On Sun, 2009-03-08 at 15:43 +0530, Jaswinder Singh Rajput wrote:
> +/*
> + * Exported because of ACPI idle
> + */
> u64 hw_perf_save_disable(void)
> {
> if (unlikely(!perf_counters_initialized))
> @@ -270,9 +272,6 @@ u64 hw_perf_save_disable(void)
>
> return pmc_ops->save_disable_all();
> }
> -/*
> - * Exported because of ACPI idle
> - */
> EXPORT_SYMBOL_GPL(hw_perf_save_disable);
>
> static void pmc_intel_restore_all(u64 ctrl)
> @@ -301,6 +300,9 @@ static void pmc_amd_restore_all(u64 ctrl)
> }
> }
>
> +/*
> + * Exported because of ACPI idle
> + */
> void hw_perf_restore(u64 ctrl)
> {
> if (unlikely(!perf_counters_initialized))
> @@ -308,9 +310,6 @@ void hw_perf_restore(u64 ctrl)
>
> pmc_ops->restore_all(ctrl);
> }
> -/*
> - * Exported because of ACPI idle
> - */
> EXPORT_SYMBOL_GPL(hw_perf_restore);
Please leave those comments where they are, they do not describe the
function, but comment on the export.
next prev parent reply other threads:[~2009-03-08 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-08 10:13 [git-pull -tip] x86:perf_counter cleanup Jaswinder Singh Rajput
2009-03-08 10:20 ` Peter Zijlstra [this message]
2009-03-08 10:39 ` Jaswinder Singh Rajput
2009-03-08 10:41 ` Ingo Molnar
2009-03-08 11:39 ` Jaswinder Singh Rajput
2009-03-08 10:46 ` Peter Zijlstra
2009-03-08 10:32 ` Peter Zijlstra
2009-03-08 10:34 ` Peter Zijlstra
2009-03-08 15:52 ` [tip:perfcounters/core] x86: perf_counter cleanup Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236507643.22914.3642.camel@twins \
--to=peterz@infradead.org \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox