public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stoyan Gaydarov <stoyboyker@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Stoyan Gaydarov <stoyboyker@gmail.com>,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
	linux-s390@vger.kernel.org
Subject: [PATCH 09/25] [s390] BUG to BUG_ON changes
Date: Tue, 10 Mar 2009 00:10:34 -0500	[thread overview]
Message-ID: <1236661850-8237-10-git-send-email-stoyboyker@gmail.com> (raw)
In-Reply-To: <1236661850-8237-9-git-send-email-stoyboyker@gmail.com>

Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
---
 arch/s390/kernel/debug.c      |    3 +--
 arch/s390/kernel/setup.c      |    3 +--
 drivers/s390/char/tape_3590.c |    3 +--
 drivers/s390/char/tape_core.c |    6 ++----
 drivers/s390/char/tape_std.c  |    4 ++--
 5 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index ba03fc0..39137b9 100644
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -698,8 +698,7 @@ debug_info_t *debug_register_mode(const char *name, int pages_per_area,
 	if ((uid != 0) || (gid != 0))
 		pr_warning("Root becomes the owner of all s390dbf files "
 			   "in sysfs\n");
-	if (!initialized)
-		BUG();
+	BUG_ON(!initialized);
 	mutex_lock(&debug_mutex);
 
         /* create new debug_info */
diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c
index c5cfb61..bfbbd19 100644
--- a/arch/s390/kernel/setup.c
+++ b/arch/s390/kernel/setup.c
@@ -125,8 +125,7 @@ void __cpuinit cpu_init(void)
 
 	atomic_inc(&init_mm.mm_count);
 	current->active_mm = &init_mm;
-        if (current->mm)
-                BUG();
+        BUG_ON(current->mm);
         enter_lazy_tlb(&init_mm, current);
 }
 
diff --git a/drivers/s390/char/tape_3590.c b/drivers/s390/char/tape_3590.c
index 71605a1..cdb5222 100644
--- a/drivers/s390/char/tape_3590.c
+++ b/drivers/s390/char/tape_3590.c
@@ -661,8 +661,7 @@ tape_3590_bread(struct tape_device *device, struct request *req)
 			ccw++;
 			dst += TAPEBLOCK_HSEC_SIZE;
 		}
-		if (off > bv->bv_len)
-			BUG();
+		BUG_ON(off > bv->bv_len);
 	}
 	ccw = tape_ccw_end(ccw, NOP, 0, NULL);
 	DBF_EVENT(6, "xBREDccwg\n");
diff --git a/drivers/s390/char/tape_core.c b/drivers/s390/char/tape_core.c
index f9bb51f..bb04f9a 100644
--- a/drivers/s390/char/tape_core.c
+++ b/drivers/s390/char/tape_core.c
@@ -639,8 +639,7 @@ tape_alloc_request(int cplength, int datasize)
 {
 	struct tape_request *request;
 
-	if (datasize > PAGE_SIZE || (cplength*sizeof(struct ccw1)) > PAGE_SIZE)
-		BUG();
+	BUG_ON(datasize > PAGE_SIZE || (cplength*sizeof(struct ccw1)) > PAGE_SIZE);
 
 	DBF_LH(6, "tape_alloc_request(%d, %d)\n", cplength, datasize);
 
@@ -797,8 +796,7 @@ static void tape_long_busy_timeout(unsigned long data)
 	device = (struct tape_device *) data;
 	spin_lock_irq(get_ccwdev_lock(device->cdev));
 	request = list_entry(device->req_queue.next, struct tape_request, list);
-	if (request->status != TAPE_REQUEST_LONG_BUSY)
-		BUG();
+	BUG_ON(request->status != TAPE_REQUEST_LONG_BUSY);
 	DBF_LH(6, "%08x: Long busy timeout.\n", device->cdev_id);
 	__tape_start_next_request(device);
 	device->lb_timeout.data = (unsigned long) tape_put_device(device);
diff --git a/drivers/s390/char/tape_std.c b/drivers/s390/char/tape_std.c
index 5bd573d..37c4447 100644
--- a/drivers/s390/char/tape_std.c
+++ b/drivers/s390/char/tape_std.c
@@ -39,8 +39,8 @@ tape_std_assign_timeout(unsigned long data)
 	int rc;
 
 	request = (struct tape_request *) data;
-	if ((device = request->device) == NULL)
-		BUG();
+	device = request->device;
+	BUG_ON(device == NULL);
 
 	DBF_EVENT(3, "%08x: Assignment timeout. Device busy.\n",
 			device->cdev_id);
-- 
1.6.1.3


  reply	other threads:[~2009-03-10  5:14 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-10  5:10 [PATCH 00/25] BUG to BUG_ON changes Stoyan Gaydarov
2009-03-10  5:10 ` [PATCH 01/25] [btrfs] " Stoyan Gaydarov
2009-03-10  5:10   ` [PATCH 02/25] [staging] " Stoyan Gaydarov
2009-03-10  5:10     ` [PATCH 03/25] [net] " Stoyan Gaydarov
2009-03-10  5:10       ` [PATCH 04/25] [arm] " Stoyan Gaydarov
2009-03-10  5:10         ` [PATCH 05/25] [ia64] " Stoyan Gaydarov
2009-03-10  5:10           ` [PATCH 06/25] [mips] " Stoyan Gaydarov
2009-03-10  5:10             ` [PATCH 07/25] [x86] " Stoyan Gaydarov
2009-03-10  5:10               ` [PATCH 08/25] [sparc] " Stoyan Gaydarov
2009-03-10  5:10                 ` Stoyan Gaydarov [this message]
2009-03-10  5:10                   ` [PATCH 10/25] [mn10300] " Stoyan Gaydarov
2009-03-10  5:10                     ` [PATCH 11/25] [alpha] " Stoyan Gaydarov
2009-03-10  5:10                       ` [PATCH 12/25] [frv] " Stoyan Gaydarov
2009-03-10  5:10                         ` [PATCH 13/25] [blackfin] " Stoyan Gaydarov
2009-03-10  5:10                           ` [PATCH 14/25] [mm] " Stoyan Gaydarov
2009-03-10  5:10                             ` [PATCH 15/25] [cris] " Stoyan Gaydarov
2009-03-10  5:10                               ` [PATCH 16/25] [m32r] " Stoyan Gaydarov
2009-03-10  5:10                                 ` [PATCH 17/25] [parisc] " Stoyan Gaydarov
2009-03-10  5:10                                   ` [PATCH 18/25] [xtensa] " Stoyan Gaydarov
2009-03-10  5:10                                     ` [PATCH 19/25] [sysctl.c] " Stoyan Gaydarov
2009-03-10  5:10                                       ` [PATCH 20/25] [scsi] " Stoyan Gaydarov
2009-03-10  5:10                                         ` [PATCH 21/25] [afs] " Stoyan Gaydarov
2009-03-10  5:10                                           ` [PATCH 22/25] [reiserfs] " Stoyan Gaydarov
2009-03-10  5:10                                             ` [PATCH 23/25] [drivers/misc] " Stoyan Gaydarov
2009-03-10  5:10                                               ` [PATCH 24/25] [crypto] " Stoyan Gaydarov
2009-03-10  5:10                                                 ` [PATCH 25/25] [drivers] " Stoyan Gaydarov
2009-03-11 11:54                                           ` [PATCH 21/25] [afs] " David Howells
2009-03-13  4:51                                   ` [PATCH 17/25] [parisc] " Kyle McMartin
2009-03-10  7:49                                 ` [PATCH 16/25] [m32r] " Hirokazu Takata
2009-04-02 11:57                               ` [PATCH 15/25] [cris] " Jesper Nilsson
2009-03-11 11:48                         ` [PATCH 12/25] [frv] " David Howells
2009-03-11 11:36                     ` [PATCH 10/25] [mn10300] " David Howells
2009-03-10 11:17                   ` [PATCH 09/25] [s390] " Christian Borntraeger
2009-03-10  5:16                 ` [PATCH 08/25] [sparc] " David Miller
2009-03-10  8:37               ` [PATCH 07/25] [x86] " Ingo Molnar
2009-03-10  8:57               ` [tip:x86/debug] x86: " Stoyan Gaydarov
2009-03-11 19:18             ` [PATCH 06/25] [mips] " Ralf Baechle
2009-03-10  5:16       ` [PATCH 03/25] [net] " David Miller
2009-03-10 10:23       ` Alexey Dobriyan
2009-03-10 11:24         ` David Miller
2009-03-10 19:54       ` Brandeburg, Jesse
2009-03-10 10:22     ` [PATCH 02/25] [staging] " Alexey Dobriyan
2009-03-10  9:16   ` [PATCH 01/25] [btrfs] " David John
2009-03-10 18:16     ` Stoyan Gaydarov
2009-03-10 18:20       ` Oliver Mattos
2009-03-10 13:24   ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236661850-8237-10-git-send-email-stoyboyker@gmail.com \
    --to=stoyboyker@gmail.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox