From: Dmitry Torokhov <dtor@chromium.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Chris Zhong <zyw@rock-chips.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
sameo@linux.intel.com, lgirdwood@gmail.com, broonie@kernel.org,
a.zummo@towertech.it, mturquette@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com, grant.likely@linaro.org,
hl@rock-chips.com, huangtao@rock-chips.com, cf@rock-chips.com,
zhangqing@rock-chips.com, xxx@rock-chips.com,
dianders@chromium.org, heiko@sntech.de, olof@lixom.net,
sonnyrao@chromium.org, javier.martinez@collabora.co.uk,
kever.yang@rock-chips.com
Subject: Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808
Date: Wed, 27 Aug 2014 10:21:38 -0700 [thread overview]
Message-ID: <12367482.Ifp3ZtRrMQ@dtor-glaptop> (raw)
In-Reply-To: <20140827133936.GD6364@lee--X1>
On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote:
> On Tue, 26 Aug 2014, Chris Zhong wrote:
> > +
> > +static struct of_device_id rk808_of_match[] = {
> > + { .compatible = "rockchip,rk808" },
> > +};
> > +MODULE_DEVICE_TABLE(of, rk808_of_match);
> > +
> > +static const struct i2c_device_id rk808_ids[] = {
> > + { "rk808" },
> > +};
> > +
> > +MODULE_DEVICE_TABLE(i2c, rk808_ids);
>
> My OCD senses are tingling. Either have a blank line above the calls
> to MODULE_DEVICE_TABLE() or don't.
Wait, don't we also need sentinel entries in both these tables?
Thanks,
Dmitry
next prev parent reply other threads:[~2014-08-27 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 14:14 [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808 Chris Zhong
2014-08-26 17:08 ` Doug Anderson
2014-08-27 13:39 ` Lee Jones
2014-08-27 15:56 ` Doug Anderson
2014-08-27 17:02 ` Lee Jones
2014-08-27 17:21 ` Dmitry Torokhov [this message]
2014-08-27 20:01 ` Doug Anderson
2014-08-28 7:33 ` Lee Jones
2014-08-27 19:53 ` Heiko Stübner
2014-08-27 19:59 ` Doug Anderson
2014-08-27 20:12 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12367482.Ifp3ZtRrMQ@dtor-glaptop \
--to=dtor@chromium.org \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kever.yang@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=sonnyrao@chromium.org \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox