Re: [tip:x86/mtrr] x86: more MTRR debug printouts

Jaswinder Singh Rajput
2009-03-13T04:28:18Z

On Fri, 2009-03-13 at 02:34 +0000, Yinghai Lu wrote:
> Commit-ID: 8ad9790588ee2e69118b2b294ddab6f3f0379ad9
> Gitweb: http://git.kernel.org/tip/8ad9790588ee2e69118b2b294ddab6f3f0379ad9
> Author: Yinghai Lu <yinghai@kernel.org>
> AuthorDate: Thu, 12 Mar 2009 18:43:54 -0700
> Commit: Ingo Molnar <mingo@elte.hu>
> CommitDate: Fri, 13 Mar 2009 02:52:18 +0100
>
> x86: more MTRR debug printouts
>
> Impact: improve MTRR debugging messages
>
> There's still inefficiencies suspected with the MTRR sanitizing
> code, so make sure we get all the info we need from a dmesg.
>
> - Remove unneeded mtrr_show
>
> (It will only printout one time by first cpu, so it is no big deal.)
>
> - Also print out directly from get_mtrr, because it doesn't update mtrr_state.
>

Is there any worth moving these debug functions to
arch/x86/kernel/cpu/cpu_debug.c

By little bit changes you can desired results through:
print_msr(NULL, cpu, CPU_MTRR);

More cpu's flag available at:
arch/x86/include/asm/cpu_debug.h

by using cpu_debug you can read/write registers through kernel/user
mode.

Thanks,
--
JSR