public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Matthew Wilcox <matthew@wil.cx>, Greg KH <greg@kroah.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: more than 50 percent of dmesg belongs only to PCI and USB
Date: Mon, 16 Mar 2009 10:28:49 +1100	[thread overview]
Message-ID: <1237159729.8619.7.camel@localhost> (raw)
In-Reply-To: <1237016485.2935.12.camel@ht.satnam>

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Sat, 2009-03-14 at 13:11 +0530, Jaswinder Singh Rajput wrote:
> Can we make dmesg little bit better and remove some noise and put these
> debug messages on /sys/kernel/debug/ :

I think they should just be KERN_DEBUG, that way they won't be displayed
to most users, except people who want to see them.

The problem is it's easier to write:

  dev_info(&dev->dev, "transparent bridge\n");

than:

  dev_printk(KERN_DEBUG, &dev->dev, "transparent bridge\n");

and, dev_dbg() does not do what you want in this case.


What about:

#define dev_quietly(dev, format, arg...)            \
        dev_printk(KERN_DEBUG , dev , format , ## arg)

:)

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2009-03-15 23:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-14  7:41 more than 50 percent of dmesg belongs only to PCI and USB Jaswinder Singh Rajput
2009-03-14 15:41 ` Greg KH
2009-03-15 23:28 ` Michael Ellerman [this message]
2009-03-16  0:39   ` Greg KH
2009-03-16  0:59     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237159729.8619.7.camel@localhost \
    --to=michael@ellerman.id.au \
    --cc=greg@kroah.com \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox