From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org, bzolnier@gmail.com
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 07/17] block: cleanup REQ_SOFTBARRIER usages
Date: Mon, 16 Mar 2009 11:28:50 +0900 [thread overview]
Message-ID: <1237170540-19130-8-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1237170540-19130-1-git-send-email-tj@kernel.org>
Impact: cleanup
blk_insert_request() doesn't need to worry about REQ_SOFTBARRIER.
Don't set it. Combined with recent ide updates, REQ_SOFTBARRIER is
now only used in elevator proper and for discard requests.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
block/blk-core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index d7b2cc9..9e5f154 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -944,7 +944,6 @@ void blk_insert_request(struct request_queue *q, struct request *rq,
* barrier
*/
rq->cmd_type = REQ_TYPE_SPECIAL;
- rq->cmd_flags |= REQ_SOFTBARRIER;
rq->special = data;
--
1.6.0.2
next prev parent reply other threads:[~2009-03-16 2:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 2:28 [GIT PATCH] block: cleanup patches, take#2 Tejun Heo
2009-03-16 2:28 ` [PATCH 01/17] ide: use blk_run_queue() instead of blk_start_queueing() Tejun Heo
2009-03-16 2:28 ` [PATCH 02/17] ide: don't set REQ_SOFTBARRIER Tejun Heo
2009-03-16 2:28 ` [PATCH 03/17] ide: use blk_update_request() instead of blk_end_request_callback() Tejun Heo
2009-03-16 2:28 ` [PATCH 04/17] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-03-16 2:28 ` [PATCH 05/17] block: kill blk_start_queueing() Tejun Heo
2009-03-16 2:28 ` [PATCH 06/17] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-03-16 2:28 ` Tejun Heo [this message]
2009-03-16 2:28 ` [PATCH 08/17] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-03-16 2:28 ` [PATCH 09/17] block: reorder request completion functions Tejun Heo
2009-03-16 2:28 ` [PATCH 10/17] block: reorganize request fetching functions Tejun Heo
2009-03-16 2:28 ` [PATCH 11/17] block: kill blk_end_request_callback() Tejun Heo
2009-03-16 2:28 ` [PATCH 12/17] block: clean up request completion API Tejun Heo
2009-03-16 2:28 ` [PATCH 13/17] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-03-16 2:28 ` [PATCH 14/17] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-03-16 2:28 ` [PATCH 15/17] block: kill end_request() Tejun Heo
2009-03-16 3:23 ` Grant Likely
2009-03-16 3:27 ` Grant Likely
2009-03-21 2:58 ` Tejun Heo
2009-03-24 11:37 ` Jens Axboe
2009-03-24 13:07 ` Tejun Heo
2009-03-16 2:28 ` [PATCH 16/17] ubd: simplify block request completion Tejun Heo
2009-03-16 2:29 ` [PATCH 17/17] block: clean up unnecessary stuff from block drivers Tejun Heo
2009-03-16 17:53 ` [GIT PATCH] block: cleanup patches, take#2 Bartlomiej Zolnierkiewicz
2009-03-17 0:10 ` Tejun Heo
2009-03-18 17:17 ` Bartlomiej Zolnierkiewicz
2009-03-19 0:19 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237170540-19130-8-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox