From: Jiri Slaby <jirislaby@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [PATCH 1/2] Char: isicom, prolong tty reference holding
Date: Mon, 16 Mar 2009 11:34:24 +0100 [thread overview]
Message-ID: <1237199665-10675-1-git-send-email-jirislaby@gmail.com> (raw)
Hold the tty reference a bit longer in isicom_shutdown_port, because
we use it later in the function, so that it won't disappear in the
meantime.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
drivers/char/isicom.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c
index 24aa6e8..855f375 100644
--- a/drivers/char/isicom.c
+++ b/drivers/char/isicom.c
@@ -897,8 +897,6 @@ static void isicom_shutdown_port(struct isi_port *port)
tty_port_free_xmit_buf(&port->port);
port->port.flags &= ~ASYNC_INITIALIZED;
- /* 3rd October 2000 : Vinayak P Risbud */
- tty_port_tty_set(&port->port, NULL);
/*Fix done by Anil .S on 30-04-2001
remote login through isi port has dtr toggle problem
@@ -925,6 +923,7 @@ static void isicom_shutdown_port(struct isi_port *port)
if (!card->count)
isicom_shutdown_board(card);
}
+ tty_port_tty_set(&port->port, NULL);
}
static void isicom_flush_buffer(struct tty_struct *tty)
--
1.6.2
next reply other threads:[~2009-03-16 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 10:34 Jiri Slaby [this message]
2009-03-16 10:34 ` [PATCH 2/2] Char: isicom, fix build warning Jiri Slaby
2009-03-16 10:50 ` [PATCH 1/2] Char: isicom, prolong tty reference holding Alan Cox
2009-03-16 10:56 ` Jiri Slaby
2009-03-16 10:59 ` Jiri Slaby
2009-03-16 11:09 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237199665-10675-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox