* [Patch] relay: fix signedness in subbuf_splice_actor()
@ 2009-03-16 11:24 Martin Peschke
0 siblings, 0 replies; only message in thread
From: Martin Peschke @ 2009-03-16 11:24 UTC (permalink / raw)
To: Tom Zanussi; +Cc: linux-kernel, linux-s390
From: Martin Peschke <mpeschke@linux.vnet.ibm.com>
The variable ret is used as a signed value.
Found by a statical code analysis tool.
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
---
kernel/relay.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -1227,7 +1227,8 @@ static int subbuf_splice_actor(struct fi
unsigned int flags,
int *nonpad_ret)
{
- unsigned int pidx, poff, total_len, subbuf_pages, nr_pages, ret;
+ unsigned int pidx, poff, total_len, subbuf_pages, nr_pages;
+ int ret;
struct rchan_buf *rbuf = in->private_data;
unsigned int subbuf_size = rbuf->chan->subbuf_size;
uint64_t pos = (uint64_t) *ppos;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-16 11:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-16 11:24 [Patch] relay: fix signedness in subbuf_splice_actor() Martin Peschke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox