Re: [PATCH -tip] x86: move vmware to hypervisor

[Jaswinder Singh Rajput <jaswinder@kernel.org>]

On Tue, 2009-03-17 at 10:39 +0100, Ingo Molnar wrote:
> * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> 
> > Subject: [PATCH] x86: move vmware to hypervisor
> > 
> > Impact: cleanup
> > 
> > vmware is only required by hypervisor and having only two functions
> > by moving these two functions to hypervisor we get rid of 2 vmware files
> > 
> > Added support for CONFIG_X86_HYPERVISOR
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > ---
> >  arch/x86/Kconfig                  |   12 ++++
> >  arch/x86/include/asm/hypervisor.h |   34 ++++++++++-
> >  arch/x86/include/asm/vmware.h     |   27 ---------
> >  arch/x86/kernel/cpu/Makefile      |    2 +-
> >  arch/x86/kernel/cpu/hypervisor.c  |   80 ++++++++++++++++++++-------
> >  arch/x86/kernel/cpu/vmware.c      |  112 -------------------------------------
> >  6 files changed, 104 insertions(+), 163 deletions(-)
> >  delete mode 100644 arch/x86/include/asm/vmware.h
> >  delete mode 100644 arch/x86/kernel/cpu/vmware.c
> 
> I dont really like this one. KVM is a hypervisor too, and so is 
> Xen and lguest. VMware is one of the many types of a 
> hypervisors.
> 

Can we use common hypervisor for Xen, lguest, vmware, etc.
And Xen, lguest, vmware will be the sub-options.

--
JSR