[PATCH] radio-mr800.c: Missing mutex include

[PATCH] radio-mr800.c: Missing mutex include

[Alessio Igor Bogani]

radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
pulled in indirectly by one of the headers it already includes, the
right thing is to include it directly.

Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
---
 drivers/media/radio/radio-mr800.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/radio/radio-mr800.c b/drivers/media/radio/radio-mr800.c
index fdfc7bf..4d91148 100644
--- a/drivers/media/radio/radio-mr800.c
+++ b/drivers/media/radio/radio-mr800.c
@@ -58,6 +58,7 @@
 #include <media/v4l2-ioctl.h>
 #include <linux/usb.h>
 #include <linux/version.h>	/* for KERNEL_VERSION MACRO */
+#include <linux/mutex.h>
 
 /* driver and module definitions */
 #define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>"
-- 
1.6.0.4

Re: [PATCH] radio-mr800.c: Missing mutex include

[Alexey Klimov]

On Tue, 2009-03-17 at 22:00 +0100, Alessio Igor Bogani wrote:
> radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> pulled in indirectly by one of the headers it already includes, the
> right thing is to include it directly.


Hello, Alessio

Patch looks okay for my eyes.
If it useful it should be applied.

Thank you!

Mauro, if patch is okay please apply it.
If you need my ack - here it is:
Acked-by: Alexey Klimov <klimov.linux@gmail.com>

-- 
Best regards, Klimov Alexey

Re: [PATCH] radio-mr800.c: Missing mutex include

[Mauro Carvalho Chehab]

On Wed, 18 Mar 2009 00:42:08 +0300
Alexey Klimov <klimov.linux@gmail.com> wrote:

> On Tue, 2009-03-17 at 22:00 +0100, Alessio Igor Bogani wrote:
> > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > pulled in indirectly by one of the headers it already includes, the
> > right thing is to include it directly.
> 
> 
> Hello, Alessio
> 
> Patch looks okay for my eyes.
> If it useful it should be applied.
> 
> Thank you!
> 
> Mauro, if patch is okay please apply it.
> If you need my ack - here it is:
> Acked-by: Alexey Klimov <klimov.linux@gmail.com>

If the mutex.h were already included by another kernel header, I don't see why
to include it again. If a later patch remove the mutex.h from the header, then
the patch author should take care of this change anyway.

Cheers,
Mauro