linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Luis Henriques <henrix@sapo.pt>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Gregory Haskins <ghaskins@novell.com>
Subject: Re: [PATCH 1/2 -tip] sched: Clean unused fields from struct rq
Date: Wed, 18 Mar 2009 01:09:29 +0100	[thread overview]
Message-ID: <1237334969.5189.1242.camel@laptop> (raw)
In-Reply-To: <20090318000343.GA2189@hades.domain.com>

On Wed, 2009-03-18 at 00:03 +0000, Luis Henriques wrote:
> Since they are used on in statistics and are always set to zero, the following
> frields from struct rq have been removed: yld_exp_empty, yld_act_empty and
> yld_both_empty.
> 
> Signed-off-by: Luis Henriques <henrix@sapo.pt>
> ---

> +++ b/kernel/sched_stats.h
> @@ -26,9 +26,8 @@ static int show_schedstat(struct seq_file *seq, void *v)
>  
>  		/* runqueue-specific stats */
>  		seq_printf(seq,
> -		    "cpu%d %u %u %u %u %u %u %u %u %u %llu %llu %lu",
> -		    cpu, rq->yld_both_empty,
> -		    rq->yld_act_empty, rq->yld_exp_empty, rq->yld_count,
> +		    "cpu%d %u %u %u %u %u %u %llu %llu %lu",
> +		    cpu, rq->yld_count,
>  		    rq->sched_switch, rq->sched_count, rq->sched_goidle,
>  		    rq->ttwu_count, rq->ttwu_local,
>  		    rq->rq_cpu_time,

I think this bit is ABI, so you either have to bump the version number
or emit 0s, iirc gregory touched some of that last -- or at least wrote
userspace for it..


  reply	other threads:[~2009-03-18  0:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  0:03 [PATCH 1/2 -tip] sched: Clean unused fields from struct rq Luis Henriques
2009-03-18  0:09 ` Peter Zijlstra [this message]
2009-03-18  0:23   ` Luis Henriques
2009-03-18  1:33     ` Gregory Haskins
2009-03-18  8:51       ` Peter Zijlstra
2009-03-18 20:08       ` Luis Henriques
2009-03-18  8:50     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237334969.5189.1242.camel@laptop \
    --to=peterz@infradead.org \
    --cc=ghaskins@novell.com \
    --cc=henrix@sapo.pt \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).