public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kbuild: work around distcc/icecc madness
Date: Fri, 20 Mar 2009 13:23:17 +0100	[thread overview]
Message-ID: <1237551797.24626.96.camel@twins> (raw)
In-Reply-To: <alpine.LFD.2.00.0903192121300.29264@localhost.localdomain>

On Thu, 2009-03-19 at 22:02 +0100, Thomas Gleixner wrote:
> Impact: workaround for distcc/icecc
> 
> Peter and I noticed that distcc and icecc based kernel compiles
> started to show random full kernel rebuilds even when nothing or just
> a .c file changed. The reason is "change of the command line" which
> caused scripts/mod/empty.o to rebuild and due to the dependencies the
> complete kernel tree. I never change the command line simply because I
> use a script for my builds.
> 
> The root cause for this problem is the check for the CFI support in
> x86 binutils. The call is generated via:
> 
>     echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -
> 
> This works fine as long as a local gcc is used or distcc/icecc use the
> local machine. When distcc/icecc offload the compile to a remote
> machine the compile fails with the following error message:
>    gcc: : No such file or directory
> 
> Now we get command lines with -DCONFIG_CFI* and without every other
> compile which causes the full rebuilds.
> 
> Digging trough the distcc/icecc code it seems that the stdin input for
> remote compiles is not handled correctly. Indeed there is some strange
> comment about this, but unfortunately no decision to compile it
> local. :(
> 
> distcc and icecc are used by many developers and we can not fix the
> versions which are out there in the wild, but we can avoid the stdin
> based call easily: echo the asm code into the temp file which is used
> for the output and use it as input file for the compiler.

Yes, this makes it mostly work again... however,

On -linus I can do:
  
# cat distmake

  #!/bin/bash

  ARCH=$1; shift

  export LD="nice -n19 ${ARCH}-linux-ld"
  export AS="distcc ${ARCH}-linux-as"
  export CC="distcc ${ARCH}-linux-gcc"

  make LD="$LD" AS="$AS" CC="$CC" -j $DISTCC_SLOTS "$@"

# distmake x86_64 bzImage

to build the tree, and then use: 

# make install

to install the resulting image. Note how the second make will use the
system gcc and not the distcc with cross arch toolchain.

This will still start a full rebuild on -tip. When I change my script to
use distmake x86_64 install, things work again after this patch.





  parent reply	other threads:[~2009-03-20 12:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 21:02 [PATCH] kbuild: work around distcc/icecc madness Thomas Gleixner
2009-03-20  9:22 ` Ingo Molnar
2009-03-20 10:31   ` Thomas Gleixner
2009-03-20 18:59     ` Ingo Molnar
2009-03-20 19:31       ` Thomas Gleixner
2009-03-20 19:33         ` Ingo Molnar
2009-03-20 20:41           ` Thomas Gleixner
2009-03-21 14:18             ` Ingo Molnar
2009-04-02 21:33               ` Thomas Gleixner
2009-04-08 16:13                 ` Ingo Molnar
2009-04-08 16:59                   ` Ingo Molnar
2009-03-20 12:23 ` Peter Zijlstra [this message]
2009-03-20 16:00   ` Thomas Gleixner
2009-03-20 19:16     ` Peter Zijlstra
2009-03-20 21:57       ` Thomas Gleixner
2009-04-02 23:56         ` Johannes Weiner
2009-04-03  0:39           ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237551797.24626.96.camel@twins \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox