From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756011AbZCVUZ2 (ORCPT ); Sun, 22 Mar 2009 16:25:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753705AbZCVUZQ (ORCPT ); Sun, 22 Mar 2009 16:25:16 -0400 Received: from hera.kernel.org ([140.211.167.34]:44386 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbZCVUZP (ORCPT ); Sun, 22 Mar 2009 16:25:15 -0400 Subject: Re: [PATCH -tip] x86: e820.h fix various signedness issues in setup.c and e820.c From: Jaswinder Singh Rajput To: Sam Ravnborg Cc: Ingo Molnar , x86 maintainers , Rusty Russell , Yinghai Lu , LKML In-Reply-To: <20090322200937.GA5887@uranus.ravnborg.org> References: <1237749831.5417.2.camel@ht.satnam> <20090322200937.GA5887@uranus.ravnborg.org> Content-Type: text/plain Date: Mon, 23 Mar 2009 01:54:18 +0530 Message-Id: <1237753458.5417.9.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2009-03-22 at 21:09 +0100, Sam Ravnborg wrote: > > > > struct e820map { > > - __u32 nr_map; > > + int nr_map; > > struct e820entry map[E820_X_MAX]; > > }; > > but that header is exported so use of plain int looks wrong. > From: Jaswinder Singh Rajput Date: Mon, 23 Mar 2009 01:52:15 +0530 Subject: [PATCH] x86: e820.h fix various signedness issues in setup.c and e820.c Impact: cleanup This fixed various signedness issues in setup.c and e820.c: arch/x86/kernel/setup.c:455:53: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/setup.c:455:53: expected int *pnr_map arch/x86/kernel/setup.c:455:53: got unsigned int extern [toplevel] * arch/x86/kernel/setup.c:639:53: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/setup.c:639:53: expected int *pnr_map arch/x86/kernel/setup.c:639:53: got unsigned int extern [toplevel] * arch/x86/kernel/setup.c:820:54: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/setup.c:820:54: expected int *pnr_map arch/x86/kernel/setup.c:820:54: got unsigned int extern [toplevel] * arch/x86/kernel/e820.c:670:53: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/e820.c:670:53: expected int *pnr_map arch/x86/kernel/e820.c:670:53: got unsigned int [toplevel] * Signed-off-by: Jaswinder Singh Rajput --- arch/x86/include/asm/e820.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h index 00d41ce..991ac17 100644 --- a/arch/x86/include/asm/e820.h +++ b/arch/x86/include/asm/e820.h @@ -57,7 +57,7 @@ struct e820entry { } __attribute__((packed)); struct e820map { - __u32 nr_map; + __s32 nr_map; struct e820entry map[E820_X_MAX]; }; -- 1.6.0.6