public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 5/5] tracing/ftrace: make nop using polling wait for events on pipe
Date: Sun, 22 Mar 2009 23:10:47 +0100	[thread overview]
Message-ID: <1237759847-21025-5-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1237759847-21025-1-git-send-email-fweisbec@gmail.com>

Impact: display events when they arrive

Now that the events don't use wake_up() anymore, we need the nop
tracer to poll waiting for events on the pipe. Especially because
nop is useful to look at orphans traces types (traces types that
don't rely on specific tracers) because it doesn't produce traces
itself.

And unlike other tracers that trigger specific traces periodically,
nop triggers no traces by itself that can wake him.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 kernel/trace/trace_nop.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/trace_nop.c b/kernel/trace/trace_nop.c
index 9aa84bd..394f944 100644
--- a/kernel/trace/trace_nop.c
+++ b/kernel/trace/trace_nop.c
@@ -91,6 +91,7 @@ struct tracer nop_trace __read_mostly =
 	.name		= "nop",
 	.init		= nop_trace_init,
 	.reset		= nop_trace_reset,
+	.wait_pipe	= poll_wait_pipe,
 #ifdef CONFIG_FTRACE_SELFTEST
 	.selftest	= trace_selftest_startup_nop,
 #endif
-- 
1.6.1


  parent reply	other threads:[~2009-03-22 22:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 22:10 [PATCH 1/5] tracing/events: make the filter files writable Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 2/5] debugfs: function to know if debugfs is initialized Frederic Weisbecker
2009-03-23  8:18   ` Ingo Molnar
2009-03-23 14:41     ` Greg KH
2009-03-23 16:08       ` Ingo Molnar
2009-03-23 15:57   ` [tip:tracing/ftrace] " Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 3/5] tracing/ftrace: check if debugfs is registered before creating files Frederic Weisbecker
2009-03-23  8:26   ` Ingo Molnar
2009-03-23 15:57   ` [tip:tracing/ftrace] " Frederic Weisbecker
2009-03-23 19:18   ` [PATCH 3/5] " Steven Rostedt
2009-03-23 19:22     ` Ingo Molnar
2009-03-23 19:47     ` Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 4/5] tracing/events: don't use wake up for events Frederic Weisbecker
2009-03-23  8:30   ` [tip:tracing/filters] " Frederic Weisbecker
2009-03-23 19:21     ` Steven Rostedt
2009-03-23 19:33       ` Frederic Weisbecker
2009-03-22 22:10 ` Frederic Weisbecker [this message]
2009-03-23  8:31   ` [tip:tracing/filters] tracing/ftrace: make nop-tracer use polling wait for events on pipe Frederic Weisbecker
2009-03-22 22:12 ` [PATCH 1/5] tracing/events: make the filter files writable Frederic Weisbecker
2009-03-23  8:25 ` Ingo Molnar
2009-03-23  8:31   ` Frederic Weisbecker
2009-03-23  8:30 ` [tip:tracing/filters] " Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237759847-21025-5-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox