From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965308AbcHaRvA (ORCPT ); Wed, 31 Aug 2016 13:51:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:41753 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbcHaRu5 (ORCPT ); Wed, 31 Aug 2016 13:50:57 -0400 X-AuditID: cbfee61b-f79466d000001e3c-80-57c718feca75 From: Bartlomiej Zolnierkiewicz To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland Subject: Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Date: Wed, 31 Aug 2016 19:40:21 +0200 Message-id: <12377780.GCreFUiXAa@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <0da13ae1-90a8-912b-227e-0e94439953d5@osg.samsung.com> References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <5366f8a4-b4fb-ec2d-eb1e-5534f24c4a07@kernel.org> <0da13ae1-90a8-912b-227e-0e94439953d5@osg.samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t9jAd1/EsfDDV73GFjMP3KO1eLN2zVM Fv2PXzNbnD+/gd3i8q45bBYzzu9jslh6/SKTReveI+wOHB5r5q1h9Ni0qpPNY0v/XXaPz5vk AliiuGxSUnMyy1KL9O0SuDI+7OMp2MxTsX7GBNYGxuucXYycHBICJhId22czQthiEhfurWfr YuTiEBJYyijxY1sXO4TzlVHi+be9YFVsAlYSE9tXgdkiAqYSv9a+YAUpYhb4xChx/tdrFpCE sECGxMTnl8BsFgFVifML3gM1cHDwCmhJHPzLBhIWFfCS6Nn+CGwOp4CzxIfmPywQyzYxSrxc d4QVJMErICjxY/I9sDnMAvIS+/ZPZYWwtSTW7zzONIFRYBaSsllIymYhKVvAyLyKUSK1ILmg OCk91ygvtVyvODG3uDQvXS85P3cTIzjYn0nvYDy8y/0QowAHoxIPr8ObY+FCrIllxZW5hxgl OJiVRHhzxY+HC/GmJFZWpRblxxeV5qQWH2KU5mBREud9/H9dmJBAemJJanZqakFqEUyWiYNT qoHRnLMi5NWKY3n3tu3w57hi/kpXf8Gai67Jx9+wBNRHhzHc7ubfkvb20b7TyZ2Nt65MeXND MGni/fM3ynl7ZzHVRPIlXBP5fk7t2PRjOTPO73ziVmGUVB2w0Sl58sxNMq+L+0NYQ/UvRLdb m8js3GwvcXzJhg6Gkl7WYzuZzxq7MiVv3PVl67VMJZbijERDLeai4kQAfBvw9nICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote: > > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote: > >> Hello Krzysztof, > >> > >> This series removes the usage of the skeleton.dtsi in all the Exynos dts, > >> which allows to get rid of the DTC warnings about a mismatch between the > >> memory nodes' unit names and reg properties. > >> > >> Patches are pretty trivial and shouldn't cause functional changes AFAIK, > >> but only the Exynos5 changes have been tested. The others patches were > >> just built tested. > > > > I think this is a common problem, not only Exynos-specific, so I would > > That's correct. > > > prefer to stick to common pattern. Either all DTS/DTSI include skeleton > > or none of them. > > > > The idea is to get rid of skeleton.dtsi [0], but that will of course take > time until the dtsi is removed from all the files. So this patch is a step > in the right direction so at least Exynos is not a blocker to remove it. Krzysztof's point is valid. If you are going to convert all DTS/DTSI then it is okay to apply Exynos specific changes, otherwise the code should stay as it is currently. Exynos won't be a blocker since we have your patches now and they can be applied when/if needed ;).. > > Best regards, > > Krzysztof > > > > [0]: https://lkml.org/lkml/2016/8/3/195 > > Best regards, Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics