* [PATCH] tracing/filters: free pred when clearing filters
@ 2009-03-24 7:14 Tom Zanussi
2009-03-24 7:27 ` [tip:tracing/filters] " Tom Zanussi
0 siblings, 1 reply; 2+ messages in thread
From: Tom Zanussi @ 2009-03-24 7:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, Steven Rostedt, Frédéric Weisbecker
Free the current pred when clearing the filters via the filter files.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
---
kernel/trace/trace_events.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index fdab30d..a938138 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -516,6 +516,7 @@ event_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
if (pred->clear) {
filter_free_preds(call);
+ filter_free_pred(pred);
return cnt;
}
@@ -581,6 +582,7 @@ subsystem_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
if (pred->clear) {
filter_free_subsystem_preds(system);
+ filter_free_pred(pred);
return cnt;
}
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip:tracing/filters] tracing/filters: free pred when clearing filters
2009-03-24 7:14 [PATCH] tracing/filters: free pred when clearing filters Tom Zanussi
@ 2009-03-24 7:27 ` Tom Zanussi
0 siblings, 0 replies; 2+ messages in thread
From: Tom Zanussi @ 2009-03-24 7:27 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fweisbec, tzanussi, rostedt, tglx,
mingo
Commit-ID: 09f1f245c79585383de63e3ca54d0f91824bff3a
Gitweb: http://git.kernel.org/tip/09f1f245c79585383de63e3ca54d0f91824bff3a
Author: Tom Zanussi <tzanussi@gmail.com>
AuthorDate: Tue, 24 Mar 2009 02:14:11 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 24 Mar 2009 08:26:51 +0100
tracing/filters: free pred when clearing filters
Impact: fix (small) per trace filter modification memory leak
Free the current pred when clearing the filters via the filter files.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1237878851.8339.58.camel@charm-linux>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/trace_events.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index fdab30d..a938138 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -516,6 +516,7 @@ event_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
if (pred->clear) {
filter_free_preds(call);
+ filter_free_pred(pred);
return cnt;
}
@@ -581,6 +582,7 @@ subsystem_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
if (pred->clear) {
filter_free_subsystem_preds(system);
+ filter_free_pred(pred);
return cnt;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-24 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-24 7:14 [PATCH] tracing/filters: free pred when clearing filters Tom Zanussi
2009-03-24 7:27 ` [tip:tracing/filters] " Tom Zanussi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox