From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>,
mingo@elte.hu, LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] perf_counter: fix perf_poll()
Date: Tue, 24 Mar 2009 13:21:19 +0100 [thread overview]
Message-ID: <1237897279.24918.182.camel@twins> (raw)
In-Reply-To: <1237897096.24918.181.camel@twins>
On Tue, 2009-03-24 at 13:18 +0100, Peter Zijlstra wrote:
> The below does seem to fix things (along with the previous kerneltop.c
> patch),.. however now kerneltop is going splat like:
>
> # ./kerneltop -e 1:2 -c 10
> KernelTop refresh period: 2 seconds
> ret: 1
> left: 0000000080200000
> ip: 000000008038d4ad
> right: 00000000ffffffff
> kerneltop: kerneltop.c:985: record_ip: Assertion `left <= ip && ip <= right' failed.
> Aborted
>
> Which isn't making much sense..
Seems to be an artefact of running a 32bit kerneltop on a 64bit kernel..
freshyl compiled 64bit kerneltop works just fine.
next prev parent reply other threads:[~2009-03-24 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 5:52 [PATCH] perf_counter tools: remove glib dependency and fix bugs in kerneltop.c Paul Mackerras
2009-03-24 7:57 ` Peter Zijlstra
2009-03-24 9:20 ` Ingo Molnar
2009-03-24 9:36 ` [tip:perfcounters/core] " Paul Mackerras
2009-03-24 9:38 ` Ingo Molnar
2009-03-24 10:12 ` Paul Mackerras
2009-03-24 10:14 ` Ingo Molnar
2009-03-24 10:00 ` [tip:perfcounters/core] perf_counter tools: remove glib dependency and fix bugs in kerneltop.c, fix poll() Peter Zijlstra
[not found] ` <1237875063.7530.11.camel@marge.simson.net>
[not found] ` <1237875580.7827.3.camel@marge.simson.net>
[not found] ` <1237877884.8754.2.camel@marge.simson.net>
[not found] ` <18888.38308.223722.602357@cargo.ozlabs.ibm.com>
[not found] ` <1237888224.24918.159.camel@twins>
[not found] ` <1237891863.13862.27.camel@marge.simson.net>
[not found] ` <1237892368.24918.160.camel@twins>
2009-03-24 12:18 ` [PATCH] perf_counter: fix perf_poll() Peter Zijlstra
2009-03-24 12:21 ` Peter Zijlstra [this message]
2009-03-24 12:25 ` Ingo Molnar
2009-03-24 13:06 ` [tip:perfcounters/core] " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237897279.24918.182.camel@twins \
--to=peterz@infradead.org \
--cc=arjan@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox