From: Becky Bruce <beckyb@kernel.crashing.org>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, fujita.tomonori@lab.ntt.co.jp,
ian.campbell@citrix.com, jeremy@goop.org,
Becky Bruce <beckyb@kernel.crashing.org>
Subject: [PATCH 4/5] swiotlb: map_page fix for highmem systems
Date: Tue, 24 Mar 2009 16:28:45 -0500 [thread overview]
Message-ID: <1237930126-6741-5-git-send-email-beckyb@kernel.crashing.org> (raw)
In-Reply-To: <1237930126-6741-4-git-send-email-beckyb@kernel.crashing.org>
The current code calls virt_to_phys() on address that might
be in highmem, which is bad. This wasn't needed, anyway, because
we already have the physical address we need. Get rid of the
now-unused virtual address as well.
Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
---
lib/swiotlb.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index c152f17..b33180e 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -640,7 +640,6 @@ dma_addr_t swiotlb_map_page(struct device *dev, struct page *page,
struct dma_attrs *attrs)
{
phys_addr_t phys = page_to_phys(page) + offset;
- void *ptr = page_address(page) + offset;
dma_addr_t dev_addr = swiotlb_phys_to_bus(dev, phys);
void *map;
@@ -651,7 +650,7 @@ dma_addr_t swiotlb_map_page(struct device *dev, struct page *page,
* buffering it.
*/
if (!address_needs_mapping(dev, dev_addr, size) &&
- !range_needs_mapping(virt_to_phys(ptr), size))
+ !range_needs_mapping(phys, size))
return dev_addr;
/*
--
1.5.6.6
next prev parent reply other threads:[~2009-03-24 21:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:28 [PATCH 0/5] swiotlb: changes for powerpc/highmem Becky Bruce
2009-03-24 21:28 ` [PATCH 1/5] swiotlb: comment corrections (no code changes) Becky Bruce
2009-03-24 21:28 ` [PATCH 2/5] swiotlb: fix compile warning Becky Bruce
2009-03-24 21:28 ` [PATCH 3/5] swiotlb: swiotlb_bus_to_virt/phys prototype changes Becky Bruce
2009-03-24 21:28 ` Becky Bruce [this message]
2009-03-24 21:28 ` [PATCH 5/5] swiotlb: Allow arch override of address_needs_mapping Becky Bruce
2009-03-25 2:58 ` FUJITA Tomonori
2009-03-25 2:58 ` [PATCH 4/5] swiotlb: map_page fix for highmem systems FUJITA Tomonori
2009-03-25 2:58 ` [PATCH 3/5] swiotlb: swiotlb_bus_to_virt/phys prototype changes FUJITA Tomonori
2009-03-25 3:54 ` Becky Bruce
2009-03-25 12:44 ` Ingo Molnar
2009-03-25 2:58 ` [PATCH 2/5] swiotlb: fix compile warning FUJITA Tomonori
2009-03-25 3:42 ` Becky Bruce
2009-03-25 3:52 ` FUJITA Tomonori
2009-03-25 12:45 ` Ingo Molnar
2009-03-25 13:03 ` Becky Bruce
2009-03-27 17:13 ` [PATCH 0/5] swiotlb: changes for powerpc/highmem Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237930126-6741-5-git-send-email-beckyb@kernel.crashing.org \
--to=beckyb@kernel.crashing.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox