Re: [patch 6/9] LTTng instrumentation - timer

Thomas Gleixner
2009-03-27T22:08:26Z

On Tue, 24 Mar 2009, Ingo Molnar wrote:

>
> * Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > On Tue, 24 Mar 2009, Ingo Molnar wrote:
> > > the init methods are missing from your patch entirely - and the rest
> > > is partially incomplete as well.
> > >
> > > Instrumentation of the del_timer() variants is missing. For a
> > > complete lifetime analysis of timers this cannot be left out.
> >
> > Look at the debugobjects hooks. They cover the complete timer life
> > time already.
> >
> > Piggypacking tracepoints on those would simplify maintenance and
> > reduce the number of extra lines in the code.
>
> makes sense. They dont cover itimers nor hrtimers though.

They cover all (hr)timers independent of the call site. And we really
do not need any freaking call site instrumented.

The CPU* timer stuff is a different playground and needs to be
instrumented separate.

Thanks,

tglx