Re: [patch 4/9] LTTng instrumentation softirq

Ingo Molnar
2009-03-24T18:02:38Z

* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> Compared to Jason's patch, this patch also instruments softirq raise event.

Mind sending this on top of Jason's patch, which is already applied
to the tracing tree?

Note, your instrumentation misses one source of softirq raise
events:

> @@ -300,6 +306,7 @@ void irq_exit(void)
> */
> inline void raise_softirq_irqoff(unsigned int nr)
> {
> + trace_irq_softirq_raise(nr);
> __raise_softirq_irqoff(nr);

__raise_softirq_irqoff() is used in the networking tree. It makes
little sense to instrument raise_softirq_irqoff() while not
instrumenting __raise_softirq_irqoff().

Ingo