Re: [PATCH] Suspend and Resume Support for Intel IOMMU

Linus Torvalds
2009-02-18T17:13:18Z

On Wed, 18 Feb 2009, Fenghua Yu wrote:
>
> +static int vtd_enabled;
..
> +static int iommu_resume(struct sys_device *dev)
> +{
..
> + if (!vtd_enabled)
> + return 0;

Hmm. Why do this?

Wouldn't it be much more logical to only register the iommu_sysdev if the
thing is enabled, rather than having an odd flag that gets tested at
runtime?

Linus