From: Chris Mason <chris.mason@oracle.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Jeff Layton <jlayton@redhat.com>, Ian Kent <raven@themaw.net>,
Dave Chinner <david@fromorbit.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"jens.axboe@oracle.com" <jens.axboe@oracle.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] writeback: reset inode dirty time when adding it back to empty s_dirty list
Date: Wed, 25 Mar 2009 16:07:02 -0400 [thread overview]
Message-ID: <1238011622.5676.3.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090325165500.GA6047@infradead.org>
On Wed, 2009-03-25 at 12:55 -0400, hch@infradead.org wrote:
> On Wed, Mar 25, 2009 at 08:17:43PM +0800, Wu Fengguang wrote:
> > Now there are now two possible solutions:
> > - unconditionally update dirtied_when in redirty_tail();
> > - keep dirtied_when and redirty inodes to a new dedicated queue.
> > The first one involves less code, the second one allows more flexible timing.
> >
> > NFS/XFS could be a good starting point for discussing the
> > requirements, so that we can reach a suitable solution.
>
> Note that the XFS requirement also applies to all filesystems that
> perform some sort of metadata updats on I/O completeion. That includes
> at least ext4, btrfs and most likely the cluster filesystems too.
btrfs at least doesn't dirty the inode on I/O completion. It just puts
the changes directly into the btree blocks.
-chris
next prev parent reply other threads:[~2009-03-25 20:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 20:30 [PATCH] writeback: reset inode dirty time when adding it back to empty s_dirty list Jeff Layton
2009-03-24 4:41 ` Ian Kent
2009-03-24 5:04 ` Ian Kent
2009-03-24 13:57 ` Wu Fengguang
2009-03-24 14:27 ` Ian Kent
2009-03-24 14:28 ` Jeff Layton
2009-03-24 14:46 ` Jeff Layton
2009-03-24 15:04 ` Ian Kent
2009-03-25 2:25 ` Wu Fengguang
2009-03-25 1:28 ` Wu Fengguang
2009-03-25 2:15 ` Jeff Layton
2009-03-25 2:50 ` Wu Fengguang
2009-03-25 11:51 ` Jeff Layton
2009-03-25 12:17 ` Wu Fengguang
2009-03-25 13:13 ` Jeff Layton
2009-03-25 13:18 ` Ian Kent
2009-03-25 13:38 ` Ian Kent
2009-03-25 13:44 ` Wu Fengguang
2009-03-25 14:00 ` Jeff Layton
2009-03-25 14:16 ` Wu Fengguang
2009-03-25 14:28 ` Jeff Layton
2009-03-25 14:38 ` Wu Fengguang
2009-03-26 17:03 ` Jeff Layton
2009-03-27 2:13 ` Wu Fengguang
2009-03-27 11:16 ` Jeff Layton
2009-03-28 12:44 ` Wu Fengguang
2009-03-25 16:55 ` hch
2009-03-25 20:07 ` Chris Mason [this message]
2009-03-25 2:56 ` Ian Kent
2009-03-25 3:28 ` Wu Fengguang
2009-03-25 5:03 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238011622.5676.3.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox