From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757347AbZCYUXp (ORCPT ); Wed, 25 Mar 2009 16:23:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753976AbZCYUXh (ORCPT ); Wed, 25 Mar 2009 16:23:37 -0400 Received: from hera.kernel.org ([140.211.167.34]:47747 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbZCYUXg (ORCPT ); Wed, 25 Mar 2009 16:23:36 -0400 Subject: Re: [PATCH] module: Kill warning: label 'free_init' defined but not used From: Jaswinder Singh Rajput To: Geert Uytterhoeven Cc: Masami Hiramatsu , Rusty Russell , Linux Kernel Development , Ingo Molnar , dmitri.vorobiev@movial.com In-Reply-To: <10f740e80903251305t24529e6fl1d3c850c8e4ec819@mail.gmail.com> References: <1238010885.2500.65.camel@ht.satnam> <10f740e80903251305t24529e6fl1d3c850c8e4ec819@mail.gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 26 Mar 2009 01:52:30 +0530 Message-Id: <1238012550.2500.76.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-03-25 at 21:05 +0100, Geert Uytterhoeven wrote: > On Wed, Mar 25, 2009 at 20:54, Jaswinder Singh Rajput > wrote: > > On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote: > >> On m68k (which doesn't do SMP), I get: > >> > >> | kernel/module.c:2291: warning: label 'free_init' defined but not used > >> > >> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 > >> ("module: fix refptr allocation and release order"). > >> Move the label inside the #ifdef, as the goto is protected by the same #ifdef. > >> > >> Signed-off-by: Geert Uytterhoeven > >> --- > > > > AFAIK, it is already fixed in -tip: > > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7 > > Interesting, as I noticed the problem in today's linux-next. > http://kisskb.ellerman.id.au/kisskb/buildresult/271602/ > Or am I caught again by fake warnings from the bisection process? > Yes, you are right linux-next is still having this problem. You are the third guy who came with this fix. Two of them are already applied in -tip and Rusty's tree: -----------> On Wed, 2009-03-25 at 11:35 +1030, Rusty Russell wrote: > On Wednesday 25 March 2009 02:37:19 Américo Wang wrote: > > > > Label 'free_init' is only used when defined(CONFIG_MODULE_UNLOAD) && > > defined(CONFIG_SMP), so move it inside to shut up gcc. > > Thanks, applied! > Rusty. <----------- May be you can also try linux-next tree ;-) -- JSR