From: Alexander Larsson <alexl@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: eparis@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: Issues with using fanotify for a filesystem indexer
Date: Thu, 02 Apr 2009 19:15:37 +0200 [thread overview]
Message-ID: <1238692537.5704.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20090402165023.GG3010@duck.suse.cz>
On Thu, 2009-04-02 at 18:50 +0200, Jan Kara wrote:
> On Thu 02-04-09 18:29:04, Alexander Larsson wrote:
> > Another potential issue with this is that every change bubbles up to the
> > top, modifying the recursive mtime of that. This will become very
> > contented, and may imply a partial serialization of fs activity, which
> > is kinda costly.
> Not every change - only the first change bubbles to the top, clearing the
> flag on its way. Then next change stops bubbling up as soon as it reaches
> a directory with the flag cleared. So no contention happen - we update flag
> + timestamp only at most once per scan of the directory by indexer (or
> someone else interested in recursive mtime) => once per a few minutes on
> average system.
Ah, I see. The indexer sets the flag.
I see some issues. First of all, writing the flag/mtime to disk seems
like a bad idea. It'll cause a lot of writing when the indexer recurses
throught the filesystem, similar to atimes. But, if you're not
persisting the flag/mtime then you need to keep all the dentries with
the flag set in memory, which has resource use risks similar to
unbounded event queues.
next prev parent reply other threads:[~2009-04-02 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 12:47 Issues with using fanotify for a filesystem indexer Alexander Larsson
2009-03-27 13:02 ` Al Viro
2009-03-27 13:47 ` Alexander Larsson
2009-03-28 20:38 ` Alexander Larsson
2009-04-02 14:54 ` Jan Kara
2009-04-02 16:29 ` Alexander Larsson
2009-04-02 16:50 ` Jan Kara
2009-04-02 17:15 ` Alexander Larsson [this message]
2009-04-02 19:52 ` Jan Kara
2009-04-03 6:44 ` Alexander Larsson
2009-04-03 9:33 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238692537.5704.6.camel@localhost.localdomain \
--to=alexl@redhat.com \
--cc=eparis@redhat.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox