From: David Woodhouse <dwmw2@infradead.org>
To: Greg Kroah-Hartman <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Mithlesh Thukral <mithlesh@linsyssoft.com>,
Christopher Harrer <charrer@alacritech.com>
Subject: Re: Staging: sxg: Add support to download the firmware using request_firmware()
Date: Sun, 05 Apr 2009 17:41:33 -0700 [thread overview]
Message-ID: <1238978493.11870.2.camel@macbook.infradead.org> (raw)
In-Reply-To: <200904051919.n35JJUUq031448@hera.kernel.org>
On Sun, 2009-04-05 at 19:19 +0000, Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/linus/cda3b517a478324233d9be71232b60e2e2efe848
> Commit: cda3b517a478324233d9be71232b60e2e2efe848
> Parent: e5ea8da06ba610551a75c79c1467aae379e953ce
> Author: Mithlesh Thukral <mithlesh@linsyssoft.com>
> AuthorDate: Fri Mar 20 17:39:04 2009 +0530
> Committer: Greg Kroah-Hartman <gregkh@suse.de>
> CommitDate: Fri Apr 3 14:53:14 2009 -0700
>
> Staging: sxg: Add support to download the firmware using request_firmware()
>
> Add support for downloading the firmware using kernel-builtin mechanism.
> This will remove the need for the firmware files in the driver source code.
>
> Signed-off-by: Christopher Harrer <charrer@alacritech.com>
> Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> drivers/staging/sxg/saharadbgdownload-1.71.c | 5233 ------------------------
> drivers/staging/sxg/saharadbgdownloadB-1.10.c | 5251 -------------------------
> drivers/staging/sxg/saharadownload-1.55.c | 4531 ---------------------
> drivers/staging/sxg/saharadownloadB-1.8.c | 4532 ---------------------
> drivers/staging/sxg/sxg.c | 206 +-
> firmware/Makefile | 2 +
> firmware/WHENCE | 12 +
> firmware/sxg/saharadbgdownloadB.sys.ihex | 3937 ++++++++++++++++++
> firmware/sxg/saharadownloadB.sys.ihex | 3385 ++++++++++++++++
> 9 files changed, 7437 insertions(+), 19652 deletions(-)
NO!
What the hell are you playing at, Greg?
We don't want to be adding _new_ binary firmware into the firmware/
directory -- that was only the temporary location for removing the
_existing_ crap.
We have the linux-firmware.git repository, into which we are collecting
new firmware blobs. Don't add them to the kernel sources.
This whole 'staging' clusterfuck is getting out of hand.
--
dwmw2
next parent reply other threads:[~2009-04-06 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200904051919.n35JJUUq031448@hera.kernel.org>
2009-04-06 0:41 ` David Woodhouse [this message]
2009-04-06 1:07 ` Staging: sxg: Add support to download the firmware using request_firmware() Greg KH
2009-04-06 1:19 ` David Woodhouse
2009-04-06 2:33 ` Greg KH
2009-04-06 9:10 ` Alan Cox
2009-04-06 15:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238978493.11870.2.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=charrer@alacritech.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mithlesh@linsyssoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox