Re: [GIT *] intel-iommu updates for 2.6.30 (second batch)

Ingo Molnar
2009-04-07T05:43:48Z

* Ingo Molnar <mingo@elte.hu> wrote:

> I suspect these bits are the ones that broke the upstream build:
>
> drivers/pci/dmar.c:47: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘dmar_tbl_size’
> drivers/pci/dmar.c:62: warning: ‘struct acpi_dmar_device_scope’ declared inside parameter list
> drivers/pci/dmar.c:62: warning: its scope is only this definition or declaration, which is probably not what you want
>
> config attached.

hm, it breaks on all !ACPI configs AFAICS. The whole new code
section you added to dmar.c depends on ACPI functionality.

Restricting DMAR to "depends on ACPI" in the Kconfig would probably
work but is somewhat lame: this built fine with !ACPI before and if
the hw ever gets discovered purely via the PCI space (it does not
currently) we are hardwired to ACPI only. (adding more Kconfig
dependencies also restricts testing, etc.)

Ingo