Re: [PATCH] intel-iommu: fix build with CONFIG_BRANCH_TRACER=y

Linus Torvalds
2009-04-07T14:58:11Z

On Tue, 7 Apr 2009, David Woodhouse wrote:
>
> But it's a workaround, not a fix -- if we're going to #define if() then
> we should damn well make it transparent, and not have to work around
> breakage in arbitrary places.
>
> Hence the patch I sent to Linus last night, which fixes it in the
> _right_ place:
> http://marc.info/?l=linux-kernel&m=123907505308502&w=2

Oh, Gods.

It's definitely better in the sense that if we define 'if()', we should
give it proper C semantics, but it's in some ways even uglier.

Can we please do it something like the following instead:

#define if(a, ...) \
__trace_if( (a, ## __VA_ARGS__) )

so that you don't need to do that ", ## __VA_ARGS__" thing three times?

Linus