From: Peter Zijlstra <peterz@infradead.org>
To: "figo.zhang" <figo.zhang@kolorific.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
mingo@elte.hu, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net
Subject: Re: [PATCH]kernel/sched_fair.c: the comment of the calc_delta_fair() maybe not correctly
Date: Wed, 08 Apr 2009 11:53:45 +0200 [thread overview]
Message-ID: <1239184425.24828.1373.camel@twins> (raw)
In-Reply-To: <20090408022723.22EC7F50054@mail.kolorific.com>
On Wed, 2009-04-08 at 10:27 +0800, figo.zhang wrote:
> the comment of the calc_delta_fair() maybe not correctly, should be
> delta *= NICE_0_LOAD/se->load
>
> Signed-off-by: figo.zhang <figo.zhang@kolorific.com>
>
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index 3816f21..5134b45 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -386,7 +386,7 @@ int sched_nr_latency_handler(struct ctl_table
> *table, int write, #endif
>
> /*
> - * delta /= w
> + * delta *= NICE_0_LOAD/se->load
> */
> static inline unsigned long
> calc_delta_fair(unsigned long delta, struct sched_entity *se)
The comment is conceptually correct.
NICE_0_LOAD := 1 and se->load := w, ergo, delta /= w.
prev parent reply other threads:[~2009-04-08 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 6:33 [PATCH]kernel/sched_fair.c: the comment of the calc_delta_fair() maybe not correctly figo.zhang
2009-04-07 16:57 ` Américo Wang
2009-04-08 2:27 ` figo.zhang
2009-04-08 9:53 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239184425.24828.1373.camel@twins \
--to=peterz@infradead.org \
--cc=figo.zhang@kolorific.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox