Re: 2.6.29: can't resume from suspend with DMAR (intel iommu) enabled

[David Woodhouse <dwmw2@infradead.org>]

On Fri, 2009-04-10 at 17:48 -0700, Suresh Siddha wrote:
> On Fri, 2009-04-10 at 15:46 -0700, David Woodhouse wrote:
> > On Tue, 2009-03-24 at 16:40 -0400, Kyle McMartin wrote:
> > > > Current kernel doesn't have iommu suspend/resume support yet. I'll
> > > > send out suspend/resume patches today or tomorrow. Hope that will
> > > > help. 
> > > 
> > > Heh, awesome, someone could have brought this, uhm, subtle, weakness
> > > when things were getting defaulted on...
> > 
> > git://git.infradead.org/~dwmw2/iommu-suspend-2.6.29.git
> > 
> > That's just for IOMMU, not interrupt remapping (yet).
> 
> Is this for 2.6.29-stable series? Is this really critical to have it for
> -stable?

I suspect not. We don't need it on Cantiga, and I think that's all we
really care about for 2.6.29-stable. Non-laptop chipsets, or laptop
chipsets that aren't actually out there in the wild yet, can wait for
2.6.30.

The less we have to backport, the better -- and suspend/resume support
for interrupt remapping would also require backporting a bunch of other
changes in the apic code.

At least what I have in the above tree so far is self-contained in the
VT-d code¹.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

¹ Conveniently forgetting the part where we change the definition of the
  if() macro...