From: Joe Perches <joe@perches.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Zhaolei <zhaolei@cn.fujitsu.com>,
Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] vsprintf: introduce %pf
Date: Tue, 14 Apr 2009 17:09:56 -0700 [thread overview]
Message-ID: <1239754196.28331.1.camel@localhost> (raw)
In-Reply-To: <1239753659-11790-1-git-send-email-fweisbec@gmail.com>
On Wed, 2009-04-15 at 02:00 +0200, Frederic Weisbecker wrote:
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index b56f6d0..15c9094 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -575,12 +575,15 @@ static char *string(char *buf, char *end, char *s, struct printf_spec spec)
> }
>
> static char *symbol_string(char *buf, char *end, void *ptr,
> - struct printf_spec spec)
> + struct printf_spec spec, char ext)
> {
> unsigned long value = (unsigned long) ptr;
> #ifdef CONFIG_KALLSYMS
> char sym[KSYM_SYMBOL_LEN];
> - sprint_symbol(sym, value);
> + if (ext != 'f')
> + sprint_symbol(sym, value);
> + else
> + kallsyms_lookup(value, NULL, NULL, NULL, sym);
buffer overflow waiting to happen yes?
next prev parent reply other threads:[~2009-04-15 0:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 0:00 [PATCH] vsprintf: introduce %pf Frederic Weisbecker
2009-04-15 0:09 ` Joe Perches [this message]
2009-04-15 0:13 ` Frederic Weisbecker
2009-04-15 1:57 ` Zhaolei
2009-04-15 15:26 ` Frederic Weisbecker
2009-04-15 2:17 ` Mike Frysinger
2009-04-15 2:38 ` Steven Rostedt
2009-04-15 3:13 ` KOSAKI Motohiro
2009-04-15 15:48 ` [PATCH v2] " Frederic Weisbecker
2009-04-18 17:51 ` Mike Frysinger
2009-04-29 19:09 ` [tip:core/printk] vsprintf: introduce %pf format specifier tip-bot for Frederic Weisbecker
2009-04-15 15:29 ` [PATCH] vsprintf: introduce %pf Frederic Weisbecker
2009-04-15 5:03 ` RFC: introduce struct ksymbol Joe Perches
2009-04-15 5:58 ` Ingo Molnar
2009-04-15 6:13 ` Pekka Enberg
2009-04-15 6:31 ` Ingo Molnar
2009-04-15 15:52 ` Frederic Weisbecker
2009-04-15 6:14 ` Joe Perches
2009-04-15 10:51 ` Rusty Russell
2009-04-17 7:55 ` Joe Perches
2009-04-18 16:09 ` Frederic Weisbecker
2009-04-19 2:05 ` Joe Perches
2009-04-23 1:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239754196.28331.1.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox